From 879cfd24fdb288b5b6e6877bcc3d8fd94fc672e4 Mon Sep 17 00:00:00 2001 From: Gerrit User 20117 <20117@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 29 Feb 2024 13:17:22 +0000 Subject: [PATCH] Update patch set 6 Patch Set 6: Code-Review-1 (2 comments) Patch-set: 6 Reviewer: Gerrit User 20117 <20117@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 9f397e4f344cc7b8a85ee17483084c29d4bc4bc0 Attention: {"person_ident":"Gerrit User 20117 \u003c20117@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_20117\u003e replied on the change"} --- 72e82cb7bb908411b410e3398511c23221281b9a | 44 ++++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 72e82cb7bb908411b410e3398511c23221281b9a diff --git a/72e82cb7bb908411b410e3398511c23221281b9a b/72e82cb7bb908411b410e3398511c23221281b9a new file mode 100644 index 0000000..9bd5502 --- /dev/null +++ b/72e82cb7bb908411b410e3398511c23221281b9a @@ -0,0 +1,44 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "88563baa_1a8f5eca", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 6 + }, + "lineNbr": 0, + "author": { + "id": 20117 + }, + "writtenOn": "2024-02-29T13:17:22Z", + "side": 1, + "message": "Dear Hugo,\n\nI have confused with the \"dcmanager_client\" in lots of the files.", + "revId": "72e82cb7bb908411b410e3398511c23221281b9a", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "be581923_901f18e6", + "filename": "distributedcloud-client/dcmanagerclient/commands/v1/alarm_manager.py", + "patchSetId": 6 + }, + "lineNbr": 57, + "author": { + "id": 20117 + }, + "writtenOn": "2024-02-29T13:17:22Z", + "side": 1, + "message": "The dcmanager_client makes me confused, can we update it to alarm_manager, or is there a reason we need to keep the dcmanager_client here?\nAnd other files also have the same question.", + "range": { + "startLine": 57, + "startChar": 8, + "endLine": 57, + "endChar": 24 + }, + "revId": "72e82cb7bb908411b410e3398511c23221281b9a", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file