starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 35315 \u003c35315@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35315\u003e replied on the change"}
This commit is contained in:
Gerrit User 35315 2024-02-26 13:32:37 +00:00 committed by Gerrit Code Review
parent e61474d4f8
commit 954ba1a48c
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
f2c6c153276a5aeb3b092037e8df30e5dda48e0e Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "831cb00a_fa4926cc",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_subcloud_manager.py",
"patchSetId": 5
},
"lineNbr": 95,
"author": {
"id": 35315
},
"writtenOn": "2024-02-26T13:32:37Z",
"side": 1,
"message": "Should be the new SUBCLOUD_FIELD_RESULT_LIST_SUBCLOUD_SHOW and remove the base.REGION_NAME from the added tuple.\n\nSince region_name is at the end of SUBCLOUD_FIELD_RESULT_LIST_SUBCLOUD_SHOW and both detail fields are before it, you can insert them at the index -1. Something like this:\n\n base_result \u003d base.SUBCLOUD_FIELD_RESULT_LIST_SUBCLOUD_SHOW\n base_result.insert(-1, base.EXTERNAL_OAM_FLOATING_ADDRESS)\n base_result.insert(-1, base.DEPLOY_CONFIG_SYNC_STATUS)\n self.assertEqual(base_result, actual_call[1])",
"range": {
"startLine": 95,
"startChar": 17,
"endLine": 95,
"endChar": 55
},
"revId": "f2c6c153276a5aeb3b092037e8df30e5dda48e0e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}