starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 36205 <36205@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 19319 <19319@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 36205 \u003c36205@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 19319 \u003c19319@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
This commit is contained in:
Gerrit User 31954 2024-04-22 14:46:19 +00:00 committed by Gerrit Code Review
parent 8248056f5e
commit 965ea8337b
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
f83fe08336349267b7b2d09638cf7ab9eb90a55f
View File

@ -35,6 +35,23 @@
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ae0b2d03_6aa6532a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 31954
},
"writtenOn": "2024-04-22T14:46:19Z",
"side": 1,
"message": "I would expect the enroll in phase operation also need the",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -98,6 +115,24 @@
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e3664711_23cbd33f",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
"patchSetId": 2
},
"lineNbr": 561,
"author": {
"id": 31954
},
"writtenOn": "2024-04-22T14:46:19Z",
"side": 1,
"message": "Sorry for my mistake, the deploy config should not be necessary, but the install values, BMC password should be expected to have for the factory install the subclouds, I would @kyle and @salman to comment on this topic",
"parentUuid": "036cd9dd_286611f9",
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {