Update patch set 5
Patch Set 5: Code-Review+2 (2 comments) Patch-set: 5 Reviewer: Gerrit User 33549 <33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2, 41d5cfd1d4ce27b5fb34bbdc8142f0b674d98658 Attention: {"person_ident":"Gerrit User 33549 \u003c33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33549\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33549\u003e replied on the change"}
This commit is contained in:
parent
308844d732
commit
bddc76bea3
|
@ -0,0 +1,50 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3e218132_e45c6495",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_group_manager.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 161,
|
||||
"author": {
|
||||
"id": 33549
|
||||
},
|
||||
"writtenOn": "2024-02-27T14:24:10Z",
|
||||
"side": 1,
|
||||
"message": "I was concerned that the original was a tuple, but there\u0027s no comma there so this is okay.",
|
||||
"range": {
|
||||
"startLine": 161,
|
||||
"startChar": 8,
|
||||
"endLine": 161,
|
||||
"endChar": 83
|
||||
},
|
||||
"revId": "50646f6a91e176b4d82a023a6f776e7899869eb1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "a13f6faa_c8c4aa03",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/sw_update_options_manager.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 166,
|
||||
"author": {
|
||||
"id": 33549
|
||||
},
|
||||
"writtenOn": "2024-02-27T14:24:10Z",
|
||||
"side": 1,
|
||||
"message": "I think in general it would have been better to use the client manager name for the variable rather than \u0027dcmanager_client\u0027, but it is consistent everywhere and it would be a lot of churn here to change it.",
|
||||
"range": {
|
||||
"startLine": 164,
|
||||
"startChar": 8,
|
||||
"endLine": 166,
|
||||
"endChar": 1
|
||||
},
|
||||
"revId": "50646f6a91e176b4d82a023a6f776e7899869eb1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue