starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Workflow-1

(7 comments)

Patch-set: 6
Reviewer: Gerrit User 14675 <14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=-1, 6dbedd5f3db0efd373ead4b7cadafb5c53000562
Attention: {"person_ident":"Gerrit User 33549 \u003c33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
This commit is contained in:
Gerrit User 14675 2024-02-15 22:01:24 +00:00 committed by Gerrit Code Review
parent 881dc14ff9
commit bf3eaae3c4
2 changed files with 161 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

144
205860da9a5c5893ca1b9ebab2007e5137e1e5a6
View File

@ -23,6 +23,30 @@
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d89a525f_a8085847",
"filename": "distributedcloud-client/.pylintrc",
"patchSetId": 5
},
"lineNbr": 33,
"author": {
"id": 14675
},
"writtenOn": "2024-02-15T22:01:24Z",
"side": 1,
"message": "I just \"copied\" the same rules from the distcloud, but I didn\u0027t review them. You\u0027re right; I will check all the rules to see if we can fix them without too much changes. Thanks.",
"parentUuid": "79110e6f_d55138ea",
"range": {
"startLine": 33,
"startChar": 8,
"endLine": 33,
"endChar": 31
},
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fe56de8d_e051370b",
"filename": "distributedcloud-client/.pylintrc",
"patchSetId": 5
},
"lineNbr": 40,
"author": {
"id": 14675
},
"writtenOn": "2024-02-15T22:01:24Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "0c3264d4_9793c9b5",
"range": {
"startLine": 40,
"startChar": 8,
"endLine": 40,
"endChar": 24
},
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0b4671cf_b5a713eb",
"filename": "distributedcloud-client/.pylintrc",
"patchSetId": 5
},
"lineNbr": 42,
"author": {
"id": 14675
},
"writtenOn": "2024-02-15T22:01:24Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "637c5b8b_9bdfe432",
"range": {
"startLine": 42,
"startChar": 8,
"endLine": 42,
"endChar": 29
},
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -92,6 +164,30 @@
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8da16a0e_f1152e16",
"filename": "distributedcloud-client/.pylintrc",
"patchSetId": 5
},
"lineNbr": 46,
"author": {
"id": 14675
},
"writtenOn": "2024-02-15T22:01:24Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "a04e7342_5ec36d4b",
"range": {
"startLine": 46,
"startChar": 8,
"endLine": 46,
"endChar": 24
},
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -115,6 +211,30 @@
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ca6c8691_9b7f9ead",
"filename": "distributedcloud-client/.pylintrc",
"patchSetId": 5
},
"lineNbr": 49,
"author": {
"id": 14675
},
"writtenOn": "2024-02-15T22:01:24Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "73b469be_622323e9",
"range": {
"startLine": 49,
"startChar": 8,
"endLine": 49,
"endChar": 26
},
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -137,6 +257,30 @@
},
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ce7aa821_2fbea8e2",
"filename": "distributedcloud-client/.pylintrc",
"patchSetId": 5
},
"lineNbr": 64,
"author": {
"id": 14675
},
"writtenOn": "2024-02-15T22:01:24Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "6754e182_791a02ef",
"range": {
"startLine": 64,
"startChar": 8,
"endLine": 64,
"endChar": 20
},
"revId": "205860da9a5c5893ca1b9ebab2007e5137e1e5a6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

17
e418803bd3c9643b848911917ee3c53d3752ee03
View File

@ -16,6 +16,23 @@
"message": "Some questions around what we have disabled now by default - concerned that they may mask some issues if turned off.",
"revId": "e418803bd3c9643b848911917ee3c53d3752ee03",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a5e713ae_d9d020dd",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 14675
},
"writtenOn": "2024-02-15T22:01:24Z",
"side": 1,
"message": "Checking all the disabled rules to see if it\u0027s possible to quickly fix them.",
"revId": "e418803bd3c9643b848911917ee3c53d3752ee03",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}