starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(1 comment)

Patch-set: 12
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
This commit is contained in:
Gerrit User 14675 2024-02-27 19:15:50 +00:00 committed by Gerrit Code Review
parent 0fd2fd7ec3
commit d2166aa9de
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
b090dbb88017b8cb3d82f1127ddffb4b63d5b917
View File

@ -16,6 +16,24 @@
"message": "Why did you add the sw_deploy_manager in this commit? Couldn\u0027t it be another one in the relation chain to avoid mixing the original objective for this review?",
"revId": "b090dbb88017b8cb3d82f1127ddffb4b63d5b917",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9ba16a0a_ce3a0c91",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/sw_deploy_manager.py",
"patchSetId": 12
},
"lineNbr": 7,
"author": {
"id": 14675
},
"writtenOn": "2024-02-27T19:15:50Z",
"side": 1,
"message": "hte sw_deploy_manager was merged into master, and I had to do a rebase to resolve conflicts. Currently, I\u0027m addressing the issues related to this commit and an improvement requested by the core reviewer.",
"parentUuid": "021c5e48_c4849453",
"revId": "b090dbb88017b8cb3d82f1127ddffb4b63d5b917",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}