starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(4 comments)

Patch-set: 3
Reviewer: Gerrit User 28486 <28486@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, d67db040085e1f4b38ea2b1e8d7006c16699d056
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28486\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28486 \u003c28486@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28486\u003e replied on the change"}
This commit is contained in:
Gerrit User 28486 2024-02-14 20:51:43 +00:00 committed by Gerrit Code Review
parent 318ef3cc36
commit d456fc32a9
1 changed files with 81 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
c3853dd159d2800e4327ac14ffdff65e5513b44d
View File

@ -17,6 +17,29 @@
"revId": "c3853dd159d2800e4327ac14ffdff65e5513b44d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cbba440a_9c78e6ea",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 22,
"author": {
"id": 28486
},
"writtenOn": "2024-02-14T20:51:43Z",
"side": 1,
"message": "1. Verify that command software-deploy-strategy create without --release-id option fails\n2. Verify that command software-deploy-strategy create --release-id is process successfully\n\nMissing software-deploy-strategy show test",
"range": {
"startLine": 17,
"startChar": 0,
"endLine": 22,
"endChar": 0
},
"revId": "c3853dd159d2800e4327ac14ffdff65e5513b44d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -34,6 +57,46 @@
"revId": "c3853dd159d2800e4327ac14ffdff65e5513b44d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6ba4477a_59a47126",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/sw_deploy_manager.py",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 28486
},
"writtenOn": "2024-02-14T20:51:43Z",
"side": 1,
"message": "Please remove to be consistent with other files and it\u0027s easier to find the inherited implementation",
"range": {
"startLine": 7,
"startChar": 57,
"endLine": 7,
"endChar": 68
},
"revId": "c3853dd159d2800e4327ac14ffdff65e5513b44d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "03f7fda4_be976ecf",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/sw_deploy_manager.py",
"patchSetId": 3
},
"lineNbr": 72,
"author": {
"id": 28486
},
"writtenOn": "2024-02-14T20:51:43Z",
"side": 1,
"message": "add pass statement to each of the classes below to be consistent with other files.",
"revId": "c3853dd159d2800e4327ac14ffdff65e5513b44d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -50,6 +113,24 @@
"message": "Is the coverage for this file enough?",
"revId": "c3853dd159d2800e4327ac14ffdff65e5513b44d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "34b305f8_9accb44e",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_sw_deploy_manager.py",
"patchSetId": 3
},
"lineNbr": 30,
"author": {
"id": 28486
},
"writtenOn": "2024-02-14T20:51:43Z",
"side": 1,
"message": "Missing test test_create_strategy_without_release_id",
"parentUuid": "6774f8c4_278d60b0",
"revId": "c3853dd159d2800e4327ac14ffdff65e5513b44d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}