Update patch set 6
Patch Set 6: Code-Review-1
(7 comments)
Patch-set: 6
Reviewer: Gerrit User 35315 <35315@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, de48ee090d9d22ab0ffe730f70a83640e4f14066
Attention: {"person_ident":"Gerrit User 31954 \u003c31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35315\u003e replied on the change"}
This commit is contained in:
Gerrit User 35315
Gerrit Code Review
parent
9e71962f4c
commit
e205b9bd5b
|
|
@ -1,5 +1,28 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2e52411c_de2b74e9",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 35315
|
||||
},
|
||||
"writtenOn": "2024-04-29T12:41:03Z",
|
||||
"side": 1,
|
||||
"message": "Missing tests:\n- All parameters being provided and verify successful request.\n- Only required parameters (in this case, only subcloud name) being provided and verify successful request.\n- Run \"dcmanager help subcloud deploy enroll\" and verify the correct help message being displayed.",
|
||||
"range": {
|
||||
"startLine": 11,
|
||||
"startChar": 0,
|
||||
"endLine": 11,
|
||||
"endChar": 9
|
||||
},
|
||||
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -22,6 +45,103 @@
|
|||
},
|
||||
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "5cf398de_bf75acf2",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 35315
|
||||
},
|
||||
"writtenOn": "2024-04-29T12:41:03Z",
|
||||
"side": 1,
|
||||
"message": "Missing story and task.",
|
||||
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "325ddafa_42ad3705",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 575,
|
||||
"author": {
|
||||
"id": 35315
|
||||
},
|
||||
"writtenOn": "2024-04-29T12:41:03Z",
|
||||
"side": 1,
|
||||
"message": "\"--install-values\", \"--bmc-password\" and \"--deploy-config\" are optional arguments, but neither of them are provided here. Before including them here, please check my other comment where I talk about the necessity of providing said parameters in this phase.",
|
||||
"range": {
|
||||
"startLine": 575,
|
||||
"startChar": 8,
|
||||
"endLine": 575,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "5c135e49_60b08a1d",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 265,
|
||||
"author": {
|
||||
"id": 35315
|
||||
},
|
||||
"writtenOn": "2024-04-29T12:41:03Z",
|
||||
"side": 1,
|
||||
"message": "Just to confirm, are we allowing enrolment of subclouds with N-1 release?",
|
||||
"range": {
|
||||
"startLine": 259,
|
||||
"startChar": 8,
|
||||
"endLine": 265,
|
||||
"endChar": 9
|
||||
},
|
||||
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2c8a0b1b_437af3ab",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_phased_subcloud_deploy.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 275,
|
||||
"author": {
|
||||
"id": 35315
|
||||
},
|
||||
"writtenOn": "2024-04-29T12:41:03Z",
|
||||
"side": 1,
|
||||
"message": "Missing tests without any any optional parameter and failure case tests.",
|
||||
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "822676bc_83cdc2f6",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_subcloud_manager.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 244,
|
||||
"author": {
|
||||
"id": 35315
|
||||
},
|
||||
"writtenOn": "2024-04-29T12:41:03Z",
|
||||
"side": 1,
|
||||
"message": "Missing failure test case (enroll and migrate being provided in the same request).",
|
||||
"revId": "f4c46c322b72910a0527cc74d84b4463143c315a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -217,6 +217,24 @@
|
|||
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "768b908c_58e88e21",
|
||||
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/phased_subcloud_deploy_manager.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 561,
|
||||
"author": {
|
||||
"id": 35315
|
||||
},
|
||||
"writtenOn": "2024-04-29T12:41:03Z",
|
||||
"side": 1,
|
||||
"message": "Don\u0027t really get why we would need install values here. My understanding is that when it\u0027s time to run enrolment, the subcloud would already be installed, and what the enrolment phase would do is just run the new enroll playbook and leave the deploy state as \"enroll-complete\" leaving the configuration to be done by deploy config or manually (and then running deploy complete).",
|
||||
"parentUuid": "1550aeaf_173ab9d3",
|
||||
"revId": "f83fe08336349267b7b2d09638cf7ab9eb90a55f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue