75 lines
2.4 KiB
Plaintext
75 lines
2.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ef6a090e_5d55d44c",
|
|
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 560,
|
|
"author": {
|
|
"id": 35230
|
|
},
|
|
"writtenOn": "2024-03-07T12:50:05Z",
|
|
"side": 1,
|
|
"message": "I\u0027m not sure this property getter/setter is really needed here. I\u0027m thinking it would work the same without it since the _info_message class attr is used directly in the produce_output and _get_resources functions.",
|
|
"range": {
|
|
"startLine": 554,
|
|
"startChar": 0,
|
|
"endLine": 560,
|
|
"endChar": 34
|
|
},
|
|
"revId": "015e1cbc4e251bc7ffe45b3b765f6bc4c83fa0bf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "cee10f4a_3394f35f",
|
|
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 560,
|
|
"author": {
|
|
"id": 34605
|
|
},
|
|
"writtenOn": "2024-03-07T15:02:29Z",
|
|
"side": 1,
|
|
"message": "Right. I forgot to remove this. This was only necessary previously for resolving the instantiation issue of subcloud_peer_group. Since the changes for subcloud_peer_group have been reverted, this is no longer needed.",
|
|
"parentUuid": "ef6a090e_5d55d44c",
|
|
"range": {
|
|
"startLine": 554,
|
|
"startChar": 0,
|
|
"endLine": 560,
|
|
"endChar": 34
|
|
},
|
|
"revId": "015e1cbc4e251bc7ffe45b3b765f6bc4c83fa0bf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "3a2007b8_6ea4bec9",
|
|
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 560,
|
|
"author": {
|
|
"id": 34605
|
|
},
|
|
"writtenOn": "2024-03-07T21:50:27Z",
|
|
"side": 1,
|
|
"message": "I have to add this back: https://zuul.opendev.org/t/openstack/build/98c9896257ca4629aba59fbde48f5046",
|
|
"parentUuid": "cee10f4a_3394f35f",
|
|
"range": {
|
|
"startLine": 554,
|
|
"startChar": 0,
|
|
"endLine": 560,
|
|
"endChar": 34
|
|
},
|
|
"revId": "015e1cbc4e251bc7ffe45b3b765f6bc4c83fa0bf",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |