starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31954 \u003c31954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31954\u003e replied on the change"}
This commit is contained in:
Gerrit User 31954 2024-05-06 15:36:59 +00:00 committed by Gerrit Code Review
parent e1f13ef205
commit 1604710f55
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
63b72d9ea542d10ceebf4f09441dd9b59ae29755 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "d6cd1862_77a9ea2b",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 12,
"author": {
"id": 31954
},
"writtenOn": "2024-05-06T15:36:59Z",
"side": 1,
"message": "Did we verify adding the subclouds w/o OpenStack endpoints created on the system controller? What\u0027s the plan to remove the endpoint?",
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f01f1c1d_47f95571",
"filename": "distributedcloud/dccommon/endpoint_cache.py",
"patchSetId": 3
},
"lineNbr": 313,
"author": {
"id": 31954
},
"writtenOn": "2024-05-06T15:36:59Z",
"side": 1,
"message": "Any consideration of not moving the two methods into the class? Can we have some unit test against these simple methods?",
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "905f5b3c_2086214a",
"filename": "distributedcloud/dccommon/endpoint_cache.py",
"patchSetId": 3
},
"lineNbr": 662,
"author": {
"id": 31954
},
"writtenOn": "2024-05-06T15:36:59Z",
"side": 1,
"message": "Can we combine the none client and the token expiry case together as they are both doing the creation?",
"revId": "63b72d9ea542d10ceebf4f09441dd9b59ae29755",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}