starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Reviewer: Gerrit User 36631 <36631@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 35805 <35805@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 35805 \u003c35805@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36631 \u003c36631@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-05-02 20:03:41 +00:00 committed by Gerrit Code Review
parent 1901f2cd19
commit 3b8d387430
1 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
eb643b580c15573800f5b72dc15549786550add6 Normal file
View File

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "1780a56e_73a7d95f",
"filename": "distributedcloud/dcorch/common/config.py",
"patchSetId": 3
},
"lineNbr": 201,
"author": {
"id": 9926
},
"writtenOn": "2024-05-02T20:03:41Z",
"side": 1,
"message": "is \u0027workers\u0027 still configurable above 1 ?",
"revId": "eb643b580c15573800f5b72dc15549786550add6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7f31ed6c_9d4eaf98",
"filename": "distributedcloud/dcorch/db/sqlalchemy/api.py",
"patchSetId": 3
},
"lineNbr": 1040,
"author": {
"id": 9926
},
"writtenOn": "2024-05-02T20:03:41Z",
"side": 1,
"message": "would there be integration considerations with the uuid proposed for \u0027region_name; and \u0027name\u0027 being used instead for the boostrap region name https://review.opendev.org/c/starlingx/ansible-playbooks/+/916310/12/playbookconfig/src/playbooks/roles/bootstrap/persist-config/files/populate_initial_config.py ?",
"range": {
"startLine": 1040,
"startChar": 34,
"endLine": 1040,
"endChar": 45
},
"revId": "eb643b580c15573800f5b72dc15549786550add6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}