starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(28 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34605\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34605 \u003c34605@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34605\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34605\u003e replied on the change"}
This commit is contained in:
Gerrit User 34605 2024-05-04 03:21:07 +00:00 committed by Gerrit Code Review
parent 5c5228b33b
commit 474bce230a
2 changed files with 618 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

576
1c9d6d294eef8fa09590fb7a78026f286ac99479
View File

@ -23,6 +23,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b5457796_a78b1b38",
"filename": "distributedcloud/dcorch/api/controllers/v1/subcloud_manager.py",
"patchSetId": 4
},
"lineNbr": 2,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "2018-2019, 2024",
"parentUuid": "9c65d844_f75fc90d",
"range": {
"startLine": 2,
"startChar": 20,
"endLine": 2,
"endChar": 21
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "faf77a58_744cafed",
"filename": "distributedcloud/dcorch/cmd/engine_worker.py",
"patchSetId": 4
},
"lineNbr": 15,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "81cf8a1a_812d5d27",
"range": {
"startLine": 2,
"startChar": 0,
"endLine": 15,
"endChar": 23
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "21074f2e_5989bb23",
"filename": "distributedcloud/dcorch/common/consts.py",
"patchSetId": 4
},
"lineNbr": 2,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "d43aeda7_1b2758b2",
"range": {
"startLine": 2,
"startChar": 0,
"endLine": 2,
"endChar": 50
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -92,6 +164,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "905b33a7_039b1d60",
"filename": "distributedcloud/dcorch/db/api.py",
"patchSetId": 4
},
"lineNbr": 16,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "f7df3254_d074994d",
"range": {
"startLine": 16,
"startChar": 0,
"endLine": 16,
"endChar": 50
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -115,6 +211,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "407020d3_66b29526",
"filename": "distributedcloud/dcorch/db/sqlalchemy/api.py",
"patchSetId": 4
},
"lineNbr": 2,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "903822b4_a73270e5",
"range": {
"startLine": 2,
"startChar": 0,
"endLine": 2,
"endChar": 50
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -138,6 +258,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3a8305f0_be1db6b0",
"filename": "distributedcloud/dcorch/db/sqlalchemy/migrate_repo/versions/008_delete_sync_lock.py",
"patchSetId": 4
},
"lineNbr": 12,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "3a6394cc_a631e8d5",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 12,
"endChar": 20
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -161,6 +305,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "09f2f253_63752cff",
"filename": "distributedcloud/dcorch/db/sqlalchemy/models.py",
"patchSetId": 4
},
"lineNbr": 2,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "37c75fad_09543780",
"range": {
"startLine": 2,
"startChar": 0,
"endLine": 2,
"endChar": 50
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -184,6 +352,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7e9d9661_db3e7c84",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 14,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "39d02525_7f5cc04f",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 14,
"endChar": 32
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -207,6 +399,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b0891671_e14d1fab",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 70,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "24251122_21114df3",
"range": {
"startLine": 69,
"startChar": 26,
"endLine": 70,
"endChar": 71
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -224,6 +440,24 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e9d64e73_517eb277",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 180,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "I\u0027m not rewriting the entire dcorch code, but splitting the managers into main and worker, so I didn\u0027t go through them line by line. Thanks for bringing this up.",
"parentUuid": "df441c37_c7253d5d",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -247,6 +481,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9e0d2063_86bdeb89",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 224,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "aecf4472_26fa9e1e",
"range": {
"startLine": 220,
"startChar": 7,
"endLine": 224,
"endChar": 24
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -264,6 +522,24 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3bb71ffc_97d457eb",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 271,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "This is what the original code owner expected. He is searching for those that do not exist and then creating them in db. There is already a log in line 238. Conversely, if it\u0027s already in db, it\u0027s an exception, so it\u0027s logged in line 267.",
"parentUuid": "d369fdd0_f0cbccc9",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -287,6 +563,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b32cfc1d_0524b0ec",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 305,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "from my opinion, I agree with the original code owner. It\u0027s unnecessary.",
"parentUuid": "6ea96f64_5d3133dd",
"range": {
"startLine": 305,
"startChar": 34,
"endLine": 305,
"endChar": 54
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -310,6 +610,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4dc58017_d8b824d2",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 317,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Agree, capabilities is unnecessary.",
"parentUuid": "9b7ff2fe_ba37b2aa",
"range": {
"startLine": 317,
"startChar": 0,
"endLine": 317,
"endChar": 42
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -333,6 +657,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "080a084c_f1aff539",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 326,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "It depends on the usage. So far, no one has called this method, but the architect wants to keep this stale code.",
"parentUuid": "9c403623_0d5e8e01",
"range": {
"startLine": 326,
"startChar": 0,
"endLine": 326,
"endChar": 72
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -356,6 +704,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5b45d69e_9fc6b638",
"filename": "distributedcloud/dcorch/engine/generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 362,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Okay.",
"parentUuid": "d44cc0d1_95867e79",
"range": {
"startLine": 361,
"startChar": 43,
"endLine": 362,
"endChar": 76
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -373,6 +745,24 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cb34ddba_48390e6b",
"filename": "distributedcloud/dcorch/engine/initial_sync_manager.py",
"patchSetId": 4
},
"lineNbr": 13,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "e7408d28_e6cdc2d1",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -396,6 +786,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0d7f6301_9853af5b",
"filename": "distributedcloud/dcorch/engine/initial_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 14,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "8ebe6d82_e96c8631",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 14,
"endChar": 32
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -413,6 +827,24 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8f54383e_61c28447",
"filename": "distributedcloud/dcorch/engine/service.py",
"patchSetId": 4
},
"lineNbr": 124,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Moved from the original. Sure, I\u0027ll correct it.",
"parentUuid": "71ac7911_8a44e171",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -430,6 +862,24 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "baefaade_74676f40",
"filename": "distributedcloud/dcorch/engine/service.py",
"patchSetId": 4
},
"lineNbr": 157,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "adce2a9a_9d0ca275",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -447,6 +897,24 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "56856702_409a6c91",
"filename": "distributedcloud/dcorch/tests/unit/engine/test_generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 30,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "5953de92_3d9c51ed",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -470,6 +938,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e4257f85_1f696300",
"filename": "distributedcloud/dcorch/tests/unit/engine/test_generic_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 114,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "I modified some code. Now the parameters are not the same. Please review the newest again. Thanks.",
"parentUuid": "378fb863_5ae9cb62",
"range": {
"startLine": 109,
"startChar": 0,
"endLine": 114,
"endChar": 67
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -487,6 +979,24 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c8953cf5_6976d7f2",
"filename": "distributedcloud/dcorch/tests/unit/engine/test_initial_sync_manager.py",
"patchSetId": 4
},
"lineNbr": 34,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "bd47b6a9_1bbaacfb",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -510,6 +1020,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b3776bd5_4dacc214",
"filename": "distributedcloud/dcorch/tests/unit/engine/test_initial_sync_manager.py",
"patchSetId": 4
},
"lineNbr": 50,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "I modified some code. Now the threadgroup was removed from the initial_sync_manager.py. Please review the newest again. Thanks.",
"parentUuid": "d6950282_d4f2749c",
"range": {
"startLine": 40,
"startChar": 0,
"endLine": 50,
"endChar": 31
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -533,6 +1067,30 @@
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b180f3f4_f810fdb0",
"filename": "distributedcloud/dcorch/tests/unit/engine/test_initial_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 63,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "8226bf93_45b6fc15",
"range": {
"startLine": 62,
"startChar": 0,
"endLine": 63,
"endChar": 55
},
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -549,6 +1107,24 @@
"message": "Same thing about being in the base class",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dd2b4914_aaa094ce",
"filename": "distributedcloud/dcorch/tests/unit/engine/test_initial_sync_worker_manager.py",
"patchSetId": 4
},
"lineNbr": 78,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "Done",
"parentUuid": "20185640_e8f858da",
"revId": "1c9d6d294eef8fa09590fb7a78026f286ac99479",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

42
eb643b580c15573800f5b72dc15549786550add6
View File

@ -17,6 +17,24 @@
"revId": "eb643b580c15573800f5b72dc15549786550add6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5a1b27ef_889b7a70",
"filename": "distributedcloud/dcorch/common/config.py",
"patchSetId": 3
},
"lineNbr": 201,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "This is for main process, so it has to be 1. I\u0027ll remove it from the config file. Thanks.",
"parentUuid": "1780a56e_73a7d95f",
"revId": "eb643b580c15573800f5b72dc15549786550add6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -39,6 +57,30 @@
},
"revId": "eb643b580c15573800f5b72dc15549786550add6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "64ebc2b0_517c44e5",
"filename": "distributedcloud/dcorch/db/sqlalchemy/api.py",
"patchSetId": 3
},
"lineNbr": 1040,
"author": {
"id": 34605
},
"writtenOn": "2024-05-04T03:21:07Z",
"side": 1,
"message": "It\u0027s better to make this change in another dedicated JIRA.",
"parentUuid": "7f31ed6c_9d4eaf98",
"range": {
"startLine": 1040,
"startChar": 34,
"endLine": 1040,
"endChar": 45
},
"revId": "eb643b580c15573800f5b72dc15549786550add6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}