starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(11 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_14675\u003e replied on the change"}
This commit is contained in:
Gerrit User 14675 2024-05-07 19:36:38 +00:00 committed by Gerrit Code Review
parent 9edbc822f9
commit 6091ef43b5
1 changed files with 258 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

258
7a8e007aa9d9ab3462edaad1338b41d8c4b8455d
View File

@ -23,6 +23,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e00fb793_5412fb43",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "Done",
"parentUuid": "a3988b02_a3187b04",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 44
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ca9aa2ae_abccabcc",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 22,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "Done",
"parentUuid": "70b3a9cf_302bd9b0",
"range": {
"startLine": 20,
"startChar": 0,
"endLine": 22,
"endChar": 42
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -86,6 +134,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "42f60d38_9a8f4183",
"filename": "distributedcloud/dcmanager/orchestrator/states/patch/updating_patches.py",
"patchSetId": 1
},
"lineNbr": 46,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "This validation is also used by the file \"created\" in line 141. If I move this to the strategy creation, we need to move the logic to get the patches as well. I\u0027m not uploading the file to the dc_vault because this parameter is a special case to apply it in the subcloud, even when it\u0027s not in the system controller.",
"parentUuid": "92a393b3_98a83253",
"range": {
"startLine": 43,
"startChar": 8,
"endLine": 46,
"endChar": 36
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -109,6 +181,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c3409d3d_0e942ae2",
"filename": "distributedcloud/dcmanager/orchestrator/states/patch/updating_patches.py",
"patchSetId": 1
},
"lineNbr": 70,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "Done",
"parentUuid": "d99d8387_ceb1bf12",
"range": {
"startLine": 70,
"startChar": 73,
"endLine": 70,
"endChar": 77
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -132,6 +228,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "19ba740c_4f3b6d92",
"filename": "distributedcloud/dcmanager/orchestrator/states/patch/updating_patches.py",
"patchSetId": 1
},
"lineNbr": 90,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "Done",
"parentUuid": "ee0ce145_8650f77f",
"range": {
"startLine": 89,
"startChar": 0,
"endLine": 90,
"endChar": 74
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -155,6 +275,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "58473650_254e14f8",
"filename": "distributedcloud/dcmanager/orchestrator/states/patch/updating_patches.py",
"patchSetId": 1
},
"lineNbr": 114,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "since the patch orchestration will be removed in future releases, I don\u0027t think the refactoring and testing are worth it.",
"parentUuid": "e17676c7_36b7cede",
"range": {
"startLine": 113,
"startChar": 20,
"endLine": 114,
"endChar": 77
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -178,6 +322,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d4389efb_38ad59d3",
"filename": "distributedcloud/dcmanager/orchestrator/states/patch/updating_patches.py",
"patchSetId": 1
},
"lineNbr": 117,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "ditto",
"parentUuid": "4eb42183_b2812722",
"range": {
"startLine": 115,
"startChar": 29,
"endLine": 117,
"endChar": 51
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -201,6 +369,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "334e315f_d9b8deb6",
"filename": "distributedcloud/dcmanager/orchestrator/sw_update_manager.py",
"patchSetId": 1
},
"lineNbr": 409,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "The use of a patch file will bypass the patch checks with the system controller. I\u0027m using the warning to ensure that the user is aware of what they are doing.",
"parentUuid": "0068659c_d471a3e9",
"range": {
"startLine": 409,
"startChar": 24,
"endLine": 409,
"endChar": 31
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -224,6 +416,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ee98eaa8_23babb63",
"filename": "distributedcloud/dcmanager/tests/unit/orchestrator/states/patch/test_updating_patches.py",
"patchSetId": 1
},
"lineNbr": 242,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "Done",
"parentUuid": "a07f9127_1e2f1319",
"range": {
"startLine": 242,
"startChar": 66,
"endLine": 242,
"endChar": 79
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -247,6 +463,30 @@
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bfa75954_d47cb6ce",
"filename": "distributedcloud/dcmanager/tests/unit/orchestrator/states/patch/test_updating_patches.py",
"patchSetId": 1
},
"lineNbr": 271,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "Done",
"parentUuid": "aa5920cd_c937f5d0",
"range": {
"startLine": 271,
"startChar": 50,
"endLine": 271,
"endChar": 58
},
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -263,6 +503,24 @@
"message": "Can you also add a test to valide the if self.stopped(): condition in https://review.opendev.org/c/starlingx/distcloud/+/917793/1/distributedcloud/dcmanager/orchestrator/states/patch/updating_patches.py#49?",
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2fde11f6_40a10fef",
"filename": "distributedcloud/dcmanager/tests/unit/orchestrator/states/patch/test_updating_patches.py",
"patchSetId": 1
},
"lineNbr": 299,
"author": {
"id": 14675
},
"writtenOn": "2024-05-07T19:36:38Z",
"side": 1,
"message": "Done",
"parentUuid": "9364cc45_321a29bd",
"revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}