Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 35230 <35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 14675 \u003c14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}

7a8e007aa9d9ab3462edaad1338b41d8c4b8455d

@@ -63,6 +63,29 @@
       "revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "92a393b3_98a83253",
+        "filename": "distributedcloud/dcmanager/orchestrator/states/patch/updating_patches.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 46,
+      "author": {
+        "id": 35230
+      },
+      "writtenOn": "2024-05-07T14:28:19Z",
+      "side": 1,
+      "message": "Besides validating it here, this validation should also happen earlier, during the strategy creation. That way the user receives the error earlier during the strategy creation and not only during the apply phase.\n\nAlso, I\u0027m wondering if instead of just passing the patch file, should we upload/copy the patch file to the dc-vault dir and use it instead? Like what we do with the config files: https://github.com/starlingx/distcloud/blob/master/distributedcloud/dcmanager/common/phased_subcloud_deploy.py#L756\n\nThat solves the issue where the strategy would fail if it\u0027s created while a specific controller is active, but applied after swacting to the standby controller.",
+      "range": {
+        "startLine": 43,
+        "startChar": 8,
+        "endLine": 46,
+        "endChar": 36
+      },
+      "revId": "7a8e007aa9d9ab3462edaad1338b41d8c4b8455d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {