From 850b041907b99e122990d74374369f91416eb802 Mon Sep 17 00:00:00 2001
From: Gerrit User 35230 <35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Wed, 24 Apr 2024 18:10:03 +0000
Subject: [PATCH] Update patch set 3

Patch Set 3:

(6 comments)

Patch-set: 3
---
 5803eb1b011549e39f96ac46dd5290ad670e2459 | 120 +++++++++++++++++++++++
 1 file changed, 120 insertions(+)

diff --git a/5803eb1b011549e39f96ac46dd5290ad670e2459 b/5803eb1b011549e39f96ac46dd5290ad670e2459
index a5fda1438..349ec9eb3 100644
--- a/5803eb1b011549e39f96ac46dd5290ad670e2459
+++ b/5803eb1b011549e39f96ac46dd5290ad670e2459
@@ -270,6 +270,126 @@
       "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "f6e9ee0d_0ebdd5f1",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1371,
+      "author": {
+        "id": 35230
+      },
+      "writtenOn": "2024-04-24T18:10:03Z",
+      "side": 1,
+      "message": "nit: change to a space",
+      "range": {
+        "startLine": 1371,
+        "startChar": 70,
+        "endLine": 1371,
+        "endChar": 71
+      },
+      "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "179ceb3f_50021eaf",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1427,
+      "author": {
+        "id": 35230
+      },
+      "writtenOn": "2024-04-24T18:10:03Z",
+      "side": 1,
+      "message": "Suggestion: add an extra assertion to verify that the get_strategy was called once, otherwise this test could pass whenever the _check_existing_vim_strategy returns false, even without reaching the \"check the system config update strategy\" block.",
+      "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "5a6a34f8_26698b38",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1764,
+      "author": {
+        "id": 35230
+      },
+      "writtenOn": "2024-04-24T18:10:03Z",
+      "side": 1,
+      "message": "nit:\n\n    rehome_data\u003d\u0027{\"saved_payload\": {\"system_mode\": \"simplex\",\u0027\n                \u0027\"bootstrap-address\": \"192.168.100.100\"}}\u0027",
+      "range": {
+        "startLine": 1763,
+        "startChar": 12,
+        "endLine": 1764,
+        "endChar": 70
+      },
+      "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e53f252f_6a97aa67",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1805,
+      "author": {
+        "id": 35230
+      },
+      "writtenOn": "2024-04-24T18:10:03Z",
+      "side": 1,
+      "message": "We need to assert that the update_subcloud was called passing the peer_group_id\u003dself.peer_group.id. Maybe something like this:\n\n    _, kwargs \u003d self.mock_rpc_client().update_subcloud.call_args\n    self.assertEqual(self.peer_group.id, kwargs.get(\u0027peer_group_id\u0027))",
+      "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1d515880_d3ed4812",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1848,
+      "author": {
+        "id": 35230
+      },
+      "writtenOn": "2024-04-24T18:10:03Z",
+      "side": 1,
+      "message": "Need to assert that the update_subcloud was called passing the peer_group_id\u003d\"none\"",
+      "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d459f949_a272ccb5",
+        "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 2243,
+      "author": {
+        "id": 35230
+      },
+      "writtenOn": "2024-04-24T18:10:03Z",
+      "side": 1,
+      "message": "nit: to avoid redefining the built-in property, use \u0027param\u0027 or \u0027field\u0027 instead.",
+      "range": {
+        "startLine": 2243,
+        "startChar": 19,
+        "endLine": 2243,
+        "endChar": 27
+      },
+      "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": false,
       "key": {