From 8b9e35fb03daed925e8d781cacf762d8afa07247 Mon Sep 17 00:00:00 2001 From: Gerrit User 35230 <35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 24 Apr 2024 12:02:14 +0000 Subject: [PATCH] Update patch set 3 Patch Set 3: (11 comments) Patch-set: 3 Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"} --- 5803eb1b011549e39f96ac46dd5290ad670e2459 | 253 +++++++++++++++++++++++ 1 file changed, 253 insertions(+) diff --git a/5803eb1b011549e39f96ac46dd5290ad670e2459 b/5803eb1b011549e39f96ac46dd5290ad670e2459 index 0ae2b6e53..a5fda1438 100644 --- a/5803eb1b011549e39f96ac46dd5290ad670e2459 +++ b/5803eb1b011549e39f96ac46dd5290ad670e2459 @@ -1,5 +1,74 @@ { "comments": [ + { + "unresolved": true, + "key": { + "uuid": "c77cefb2_d9a2eb70", + "filename": "distributedcloud/dccommon/tests/unit/test_utils.py", + "patchSetId": 3 + }, + "lineNbr": 2, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "2024", + "range": { + "startLine": 2, + "startChar": 21, + "endLine": 2, + "endChar": 25 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "9ce69f1f_0586c984", + "filename": "distributedcloud/dcmanager/tests/base.py", + "patchSetId": 3 + }, + "lineNbr": 205, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "setattr(self, name, mock_patch_object.start())", + "range": { + "startLine": 205, + "startChar": 8, + "endLine": 205, + "endChar": 55 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "7bdd7392_c382ec40", + "filename": "distributedcloud/dcmanager/tests/base.py", + "patchSetId": 3 + }, + "lineNbr": 217, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "setattr(self, name, mock_patch_object.start())", + "range": { + "startLine": 217, + "startChar": 8, + "endLine": 217, + "endChar": 55 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": false, "key": { @@ -17,6 +86,190 @@ "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "45b09ab6_bad6e965", + "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py", + "patchSetId": 3 + }, + "lineNbr": 333, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "This test seems redundant, I\u0027d remove it and rename the previous one from test_get_succeeds to test_get_succeeds_with_subcloud_id.", + "range": { + "startLine": 326, + "startChar": 0, + "endLine": 333, + "endChar": 63 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "b0e9655c_f8da8627", + "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py", + "patchSetId": 3 + }, + "lineNbr": 752, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "Docstring not matching the test name", + "range": { + "startLine": 752, + "startChar": 8, + "endLine": 752, + "endChar": 73 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "ee871fb5_9d85cfc2", + "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py", + "patchSetId": 3 + }, + "lineNbr": 804, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "Redefining the built-in \u0027property\u0027. I suggest using \u0027field\u0027 or \u0027_property\u0027 instead.\n\nSame for other uses of the \u0027property\u0027 on the next function.", + "range": { + "startLine": 804, + "startChar": 14, + "endLine": 804, + "endChar": 22 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "3f61fdd8_d8c74af6", + "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py", + "patchSetId": 3 + }, + "lineNbr": 913, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "Deleting the new fields is not necessary as unittests runs each test with fresh instances of the test class.", + "range": { + "startLine": 913, + "startChar": 8, + "endLine": 913, + "endChar": 49 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "e816415e_037a0e45", + "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py", + "patchSetId": 3 + }, + "lineNbr": 963, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "Deleting the new fields is not necessary as unittests runs each test with fresh instances of the test class.", + "range": { + "startLine": 960, + "startChar": 0, + "endLine": 963, + "endChar": 53 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "11de81e1_4256ae31", + "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py", + "patchSetId": 3 + }, + "lineNbr": 1093, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "Is this TODO still relevant?", + "range": { + "startLine": 1093, + "startChar": 0, + "endLine": 1093, + "endChar": 54 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "9a4bef86_2986613e", + "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py", + "patchSetId": 3 + }, + "lineNbr": 1157, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "The rpc method should return a dict instead of a subcloud object. You can use the db_api.subcloud_db_model_to_dict() to convert it.\n\nThis commit also applies to lines: 1517, 1610 and 1779", + "range": { + "startLine": 1157, + "startChar": 8, + "endLine": 1157, + "endChar": 75 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "01cd39c7_86810420", + "filename": "distributedcloud/dcmanager/tests/unit/api/v1/controllers/test_subclouds.py", + "patchSetId": 3 + }, + "lineNbr": 1159, + "author": { + "id": 35230 + }, + "writtenOn": "2024-04-24T12:02:14Z", + "side": 1, + "message": "Redefining the built-in \u0027property\u0027. I suggest using \u0027field\u0027 or \u0027_property\u0027 instead.", + "range": { + "startLine": 1159, + "startChar": 49, + "endLine": 1159, + "endChar": 57 + }, + "revId": "5803eb1b011549e39f96ac46dd5290ad670e2459", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": false, "key": {