From 949a514c3ffd4828cf355880819574eb814e803d Mon Sep 17 00:00:00 2001 From: Tee Ngo Date: Tue, 15 Nov 2022 21:55:43 -0500 Subject: [PATCH] Fix incorrect state transition for subcloud restore Currently the state transitions from restoring to restore-prep-failed when the restore playbook fails for whatever reason. The right state is restore-failed. This commit fixes that. Test Plan: - Perform a subcloud restore with an induced error using dcmanager subcloud-backup restore command. Verify that the deploy_status is set to restore-failed upon failing. Closes-Bug: 1996673 Change-Id: I54b84b753ab3484a1853d2a5e7e30ec6067def09 Signed-off-by: Tee Ngo --- distributedcloud/dcmanager/manager/subcloud_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/distributedcloud/dcmanager/manager/subcloud_manager.py b/distributedcloud/dcmanager/manager/subcloud_manager.py index a19418902..e65fc513d 100644 --- a/distributedcloud/dcmanager/manager/subcloud_manager.py +++ b/distributedcloud/dcmanager/manager/subcloud_manager.py @@ -1152,7 +1152,7 @@ class SubcloudManager(manager.Manager): LOG.error(msg) db_api.subcloud_update( context, subcloud.id, - deploy_status=consts.DEPLOY_STATE_RESTORE_PREP_FAILED + deploy_status=consts.DEPLOY_STATE_RESTORE_FAILED ) return False