From 04c8b51b4003986d6b979ccb1b20e62ae4cbd802 Mon Sep 17 00:00:00 2001 From: fperez Date: Tue, 26 Dec 2023 20:39:49 -0300 Subject: [PATCH] Report rehoming playbook failures This commit extends ansible error catching for rehoming subcloud operation. Test plan: PASS: Intentionally force a failure in the rehoming playbook. Verify that the error is displayed correctly Closes-bug: 2047645 Change-Id: I4571e04247bdcf273f5de860ae5032597b173ed2 Signed-off-by: fperez --- distributedcloud/dcmanager/manager/subcloud_manager.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/distributedcloud/dcmanager/manager/subcloud_manager.py b/distributedcloud/dcmanager/manager/subcloud_manager.py index fb17e6694..8fc051e58 100644 --- a/distributedcloud/dcmanager/manager/subcloud_manager.py +++ b/distributedcloud/dcmanager/manager/subcloud_manager.py @@ -796,9 +796,12 @@ class SubcloudManager(manager.Manager): f" for subcloud {subcloud.name}, check individual log at " \ f"{log_file} for detailed output." LOG.error(msg) + msg = utils.find_ansible_error_msg( + subcloud.name, log_file, consts.DEPLOY_STATE_REHOMING) db_api.subcloud_update( context, subcloud.id, - deploy_status=consts.DEPLOY_STATE_REHOME_FAILED) + deploy_status=consts.DEPLOY_STATE_REHOME_FAILED, + error_description=msg[0:consts.ERROR_DESCRIPTION_LENGTH]) return # Update the deploy status to complete and rehomed flag to true only # after playbook execution succeeded.