starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 17 

Patch Set 17:

(3 comments)

Patch-set: 17
Attention: {"person_ident":"Gerrit User 36476 \u003c36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35809 \u003c35809@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36476\u003e replied on the change"}
This commit is contained in:
Gerrit User 36476 2024-05-07 12:50:19 +00:00 committed by Gerrit Code Review
parent 55ed2190ec
commit b2f5b4aa2a
2 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
362bfbc4f4b1b8493fe1c7f27134b7514d408dc4
View File

@ -176,6 +176,24 @@
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b133eade_5ce00618",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 593,
"author": {
"id": 36476
},
"writtenOn": "2024-05-07T12:50:19Z",
"side": 1,
"message": "You said you removed it, but it is still here",
"parentUuid": "5e6ccf9c_02f3d7d2",
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

50
8712f9331da46210eb5d466bab9390dbb1b43232 Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "3871b17a_7ff15e45",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 17
},
"lineNbr": 733,
"author": {
"id": 36476
},
"writtenOn": "2024-05-07T12:50:19Z",
"side": 1,
"message": "Use f-string",
"range": {
"startLine": 731,
"startChar": 12,
"endLine": 733,
"endChar": 41
},
"revId": "8712f9331da46210eb5d466bab9390dbb1b43232",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "48dbda9a_3b257d93",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 17
},
"lineNbr": 768,
"author": {
"id": 36476
},
"writtenOn": "2024-05-07T12:50:19Z",
"side": 1,
"message": "Why are you using getattr? Can\u0027t you use updated_subcloud[key]?",
"range": {
"startLine": 768,
"startChar": 36,
"endLine": 768,
"endChar": 43
},
"revId": "8712f9331da46210eb5d466bab9390dbb1b43232",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}