starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(3 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
This commit is contained in:
Gerrit User 35230 2024-05-06 20:53:32 +00:00 committed by Gerrit Code Review
parent e1b73e98a8
commit b903446019
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
c585a4a21dbba907a3aecef7bf56a946cc50b037 Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "86714d3b_d72d16d0",
"filename": "/COMMIT_MSG",
"patchSetId": 9
},
"lineNbr": 17,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:53:32Z",
"side": 1,
"message": "Please, could you add the coverage improvements like on the other unit test commit msg? Something like: Coverage increased from X% to Y%",
"range": {
"startLine": 17,
"startChar": 9,
"endLine": 17,
"endChar": 45
},
"revId": "c585a4a21dbba907a3aecef7bf56a946cc50b037",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0ece4675_e33b4c5e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:53:32Z",
"side": 1,
"message": "LGTM, just two small comments",
"revId": "c585a4a21dbba907a3aecef7bf56a946cc50b037",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7037ae5f_b3588c24",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_system_peer_manager.py",
"patchSetId": 9
},
"lineNbr": 123,
"author": {
"id": 35230
},
"writtenOn": "2024-05-06T20:53:32Z",
"side": 1,
"message": "subcloud_id",
"revId": "c585a4a21dbba907a3aecef7bf56a946cc50b037",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}