distcloud/a68a07f3645f74030acdbb20814110a2e0a399ad

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "d78e4d18_61d87136",
        "filename": "/COMMIT_MSG",
        "patchSetId": 4
      },
      "lineNbr": 27,
      "author": {
        "id": 31954
      },
      "writtenOn": "2023-12-06T16:26:04Z",
      "side": 1,
      "message": "The code lgtm. The NA test plan will not be acceptable. Request test suggestions from @Bin Qian and @Junfeng Li",
      "revId": "a68a07f3645f74030acdbb20814110a2e0a399ad",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "96cbbe0e_189e7e75",
        "filename": "/COMMIT_MSG",
        "patchSetId": 4
      },
      "lineNbr": 27,
      "author": {
        "id": 35312
      },
      "writtenOn": "2023-12-14T16:08:34Z",
      "side": 1,
      "message": "@Junfeng Li, do you have suggestions for tests that can be performed to validate this while upgrades cannot be executed?",
      "parentUuid": "d78e4d18_61d87136",
      "revId": "a68a07f3645f74030acdbb20814110a2e0a399ad",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "59a591a1_d9936398",
        "filename": "/COMMIT_MSG",
        "patchSetId": 4
      },
      "lineNbr": 27,
      "author": {
        "id": 34895
      },
      "writtenOn": "2023-12-15T15:19:16Z",
      "side": 1,
      "message": "With designer ISOs on both end, you can run the upgrade to as far as Activation stage. If this change is excised at that point, I think we can consider the upgrade test is complete.\nIf not excised, it is better to have a tracking story/Jira for future revisit.",
      "parentUuid": "96cbbe0e_189e7e75",
      "revId": "a68a07f3645f74030acdbb20814110a2e0a399ad",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6147ca35_ec0a8b97",
        "filename": "/COMMIT_MSG",
        "patchSetId": 4
      },
      "lineNbr": 27,
      "author": {
        "id": 35312
      },
      "writtenOn": "2023-12-15T15:35:17Z",
      "side": 1,
      "message": "To validate this change, we need to have a DC with DX subcloud. Then we need the SystemController to be fully upgraded, so that we can use dcmanager\u0027s orchestration to start upgrading the DX subcloud (calling this code).\nWould that be possible with the designer ISOs?",
      "parentUuid": "59a591a1_d9936398",
      "revId": "a68a07f3645f74030acdbb20814110a2e0a399ad",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "f211ff10_82b57d2d",
        "filename": "/COMMIT_MSG",
        "patchSetId": 4
      },
      "lineNbr": 27,
      "author": {
        "id": 35312
      },
      "writtenOn": "2024-04-26T21:49:55Z",
      "side": 1,
      "message": "Resolving this. DX subcloud upgrade test was performed.",
      "parentUuid": "6147ca35_ec0a8b97",
      "revId": "a68a07f3645f74030acdbb20814110a2e0a399ad",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "29bc5859_19a4a342",
        "filename": "distributedcloud/dcmanager/common/utils.py",
        "patchSetId": 4
      },
      "lineNbr": 1119,
      "author": {
        "id": 34895
      },
      "writtenOn": "2023-12-12T22:20:55Z",
      "side": 1,
      "message": "I don\u0027t this if/else block makes too much sense. You can assign ca_crt\u003dNone at the beginning of this function. Then \u0027return tls_crt, tls_key, ca_crt\u0027. If the function caller doesn\u0027t want to use ca_crt, just use \u0027_\u0027 to ignore.\n\nAlso, the ca_crt can be unassigned before referenced as line 1103 or 1104 can throw exception before ca_crt is assigned.",
      "range": {
        "startLine": 1116,
        "startChar": 4,
        "endLine": 1119,
        "endChar": 31
      },
      "revId": "a68a07f3645f74030acdbb20814110a2e0a399ad",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "04298f0c_80f1582d",
        "filename": "distributedcloud/dcmanager/common/utils.py",
        "patchSetId": 4
      },
      "lineNbr": 1119,
      "author": {
        "id": 35312
      },
      "writtenOn": "2023-12-14T16:08:34Z",
      "side": 1,
      "message": "Done the parameter change. It doesn\u0027t need the \u0027ca_crt\u003dNone\u0027, the except block is used for re-throw, so the if the code inside the try is successful the variable will be assigned, if not it\u0027s a exception and it stops there.",
      "parentUuid": "29bc5859_19a4a342",
      "range": {
        "startLine": 1116,
        "startChar": 4,
        "endLine": 1119,
        "endChar": 31
      },
      "revId": "a68a07f3645f74030acdbb20814110a2e0a399ad",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}