Update patch set 3
Patch Set 3: (16 comments) These were a bunch of final comments I gave Abraham previously, but looks like he didn't get a chance to update the source that you were working off. Patch-set: 3
This commit is contained in:
Gerrit User 26026
Gerrit Code Review
parent
f6d0394926
commit
082264c9b3
|
|
@ -125,6 +125,374 @@
|
|||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_e0f93982",
|
||||
"filename": "doc/source/installation_guide/controller_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 48,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "500 GB (min. 10K RPM) Controller\n\n( i.e. for the Cinder LVM disk)",
|
||||
"range": {
|
||||
"startLine": 48,
|
||||
"startChar": 3,
|
||||
"endLine": 48,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_80eac59d",
|
||||
"filename": "doc/source/installation_guide/controller_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 74,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "Shouldn’t we list the xml server definitions that are created by this script ?\ne.g.\n§ Are you creating a controller-0, controller-1, compute-0, compute-1, storage-0 and storage-1 ?",
|
||||
"range": {
|
||||
"startLine": 71,
|
||||
"startChar": 0,
|
||||
"endLine": 74,
|
||||
"endChar": 0
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_e02e19f8",
|
||||
"filename": "doc/source/installation_guide/controller_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 77,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "I think you need to add a section before ‘Accessing Virtual Server Consoles’ for powering up virtual Servers\n... so that in following sections when you say “power up a server’ the guy using the virtual environment knows \nwhat to do.\ne.g.\no Powering Up a Virtual Server\n § To power up virtual server, run the following command:\n sudo virsh start \u003cserver-xml-name\u003e\n e.g.\n sudo virsh start controller-0",
|
||||
"range": {
|
||||
"startLine": 76,
|
||||
"startChar": 0,
|
||||
"endLine": 77,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_c0351d45",
|
||||
"filename": "doc/source/installation_guide/controller_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 585,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "We should just change the syntax of system host-if-modify to whatever the syntax is based on the OCTOBER STARLINGX RELEASE ... and ONLY have one command syntax",
|
||||
"range": {
|
||||
"startLine": 573,
|
||||
"startChar": 0,
|
||||
"endLine": 585,
|
||||
"endChar": 0
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_604209af",
|
||||
"filename": "doc/source/installation_guide/controller_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 772,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "... again, show only 1 syntax ... the October release",
|
||||
"range": {
|
||||
"startLine": 760,
|
||||
"startChar": 0,
|
||||
"endLine": 772,
|
||||
"endChar": 110
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_e007f96f",
|
||||
"filename": "doc/source/installation_guide/dedicated_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "Shouldn’t we list the xml server definitions that are created by this script ?\ne.g.\n§ Are you creating a controller-0, controller-1, compute-0, compute-1, storage-0 and storage-1 ?",
|
||||
"range": {
|
||||
"startLine": 74,
|
||||
"startChar": 0,
|
||||
"endLine": 78,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_c01e7dbb",
|
||||
"filename": "doc/source/installation_guide/dedicated_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "I think you need to add a section before ‘Accessing Virtual Server Consoles’ for powering up virtual Servers\n... so that in following sections when you say “power up a server’ the guy using the virtual environment knows \nwhat to do.\ne.g.\no Powering Up a Virtual Server\n § To power up virtual server, run the following command:\n sudo virsh start \u003cserver-xml-name\u003e\n e.g.\n sudo virsh start controller-0",
|
||||
"range": {
|
||||
"startLine": 81,
|
||||
"startChar": 0,
|
||||
"endLine": 81,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_801885cd",
|
||||
"filename": "doc/source/installation_guide/dedicated_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 533,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "We should just change the syntax of system host-if-modify to whatever the syntax is based on the OCTOBER STARLINGX RELEASE ... and ONLY have one command syntax",
|
||||
"range": {
|
||||
"startLine": 522,
|
||||
"startChar": 0,
|
||||
"endLine": 533,
|
||||
"endChar": 122
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_2073b11e",
|
||||
"filename": "doc/source/installation_guide/dedicated_storage.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 699,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "... again, show only 1 syntax ... the October release",
|
||||
"range": {
|
||||
"startLine": 687,
|
||||
"startChar": 0,
|
||||
"endLine": 699,
|
||||
"endChar": 110
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_6070c90a",
|
||||
"filename": "doc/source/installation_guide/duplex.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 67,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "Again should indicate xml server definitions that are created by this script",
|
||||
"range": {
|
||||
"startLine": 63,
|
||||
"startChar": 0,
|
||||
"endLine": 67,
|
||||
"endChar": 52
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_40610d38",
|
||||
"filename": "doc/source/installation_guide/duplex.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 70,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "again ...\nSAME COMMENT AS PREVIOUS FILE\no ADD ‘Powering Up a Virtual Server’ SECTION",
|
||||
"range": {
|
||||
"startLine": 70,
|
||||
"startChar": 0,
|
||||
"endLine": 70,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_a04fc1bd",
|
||||
"filename": "doc/source/installation_guide/duplex.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 177,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "you should really say “after system date/time and system mode”",
|
||||
"range": {
|
||||
"startLine": 176,
|
||||
"startChar": 32,
|
||||
"endLine": 177,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_20c171fe",
|
||||
"filename": "doc/source/installation_guide/duplex.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 676,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "REMOVE – “sudo virsh start controller-1”\no you have not said this anywhere else ... just saying “power on server” is enough and applicable to both virtual and physical scenarios",
|
||||
"range": {
|
||||
"startLine": 674,
|
||||
"startChar": 0,
|
||||
"endLine": 676,
|
||||
"endChar": 34
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_c0d19dcc",
|
||||
"filename": "doc/source/installation_guide/simplex.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 66,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "Again should indicate xml server definitions that are created by this script",
|
||||
"range": {
|
||||
"startLine": 62,
|
||||
"startChar": 0,
|
||||
"endLine": 66,
|
||||
"endChar": 52
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_20ead176",
|
||||
"filename": "doc/source/installation_guide/simplex.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 70,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "again ...\n\nSAME COMMENT AS ABOVE\no ADD ‘Powering Up a Virtual Server’ SECTION",
|
||||
"range": {
|
||||
"startLine": 69,
|
||||
"startChar": 0,
|
||||
"endLine": 70,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_c0fafd42",
|
||||
"filename": "doc/source/installation_guide/simplex.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 176,
|
||||
"author": {
|
||||
"id": 26026
|
||||
},
|
||||
"writtenOn": "2018-10-19T11:20:48Z",
|
||||
"side": 1,
|
||||
"message": "you should really say “after system date/time and system mode”",
|
||||
"range": {
|
||||
"startLine": 175,
|
||||
"startChar": 32,
|
||||
"endLine": 176,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "ed5bddca67b9a112cbc77f59a259d45d17c2f4a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue