Update patch set 1

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 31589 <31589@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, fb17efa6839b5ac17cd2c465fadbf096f0ed8943
Attention: {"person_ident":"Gerrit User 31589 \u003c31589@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31589\u003e replied on the change"}

557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88

@@ -1,5 +1,28 @@
 {
   "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "2bcecaab_b35c19e6",
+        "filename": "doc/source/node_management/kubernetes/hardware_acceleration_devices/marvell-octeon-nic-accelerator-support-0ca20e6fc2c9.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 5,
+      "author": {
+        "id": 31589
+      },
+      "writtenOn": "2024-05-03T21:53:57Z",
+      "side": 1,
+      "message": "I find the conflation of DORA and any Marvell Octeon chipset accelerators confusing.\n\nFrom the original story:\n\n \"... however as a design consideration we want to ensure that wherever possible, vendor specific implementations should be isolated or configurable so that it would be generally applicable to other Marvell Octeon Accelerators.\"\n\nDo we want to keep this as generic as possible regarding support for Marvell Octeon devices in general in the opening sentence/paragraph and then go into detail using the DORA as an example that highlights that these are not a \"standard\" NIC?\n\ne.g.\n\"The Dell Open RAN Accelerator (DORA) utilizes the OCTEON Fusion CNF95xx chipset from Marvell and it\u0027s design deviates from that of a standard network interface card (NIC) which necessitates specialized configuration. Unlike conventional NICs, the DORA requires the deployment of dedicated application software (onto the card?) prior to its operational functionality. This application software assumes responsibility for: ...\"",
+      "range": {
+        "startLine": 5,
+        "startChar": 0,
+        "endLine": 5,
+        "endChar": 38
+      },
+      "revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -160,6 +183,52 @@
       },
       "revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "167c253b_270a807f",
+        "filename": "doc/source/node_management/kubernetes/hardware_acceleration_devices/marvell-octeon-nic-accelerator-support-0ca20e6fc2c9.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 31589
+      },
+      "writtenOn": "2024-05-03T21:53:57Z",
+      "side": 1,
+      "message": "re-word:\n\n\"Any attempt to use the \u0027system\u0027 CLI to add pci-sriov VF interfaces will not succeed, although it is possible to configure it as a PCI passthrough PF interface.\"",
+      "range": {
+        "startLine": 22,
+        "startChar": 0,
+        "endLine": 24,
+        "endChar": 13
+      },
+      "revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "64176987_a015dfeb",
+        "filename": "doc/source/node_management/kubernetes/hardware_acceleration_devices/marvell-octeon-nic-accelerator-support-0ca20e6fc2c9.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 24,
+      "author": {
+        "id": 31589
+      },
+      "writtenOn": "2024-05-03T21:53:57Z",
+      "side": 1,
+      "message": "Should we add anything about being able to create VFs with raw linux commands once the drivers are loaded and the PF shows up or is that just a given?",
+      "range": {
+        "startLine": 22,
+        "startChar": 0,
+        "endLine": 24,
+        "endChar": 13
+      },
+      "revId": "557ef6d8f0dc24559b6e9e7c8bbeb4f188e9ca88",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }