starlingx
/
docs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 26026 <26026@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, d8985271b8be5aa63431c53ee035416ce53f4ccb
Attention: {"person_ident":"Gerrit User 26026 \u003c26026@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_26026\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32187 \u003c32187@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_26026\u003e replied on the change"}
This commit is contained in:
Gerrit User 26026 2024-04-24 11:16:07 +00:00 committed by Gerrit Code Review
parent 596d5973ca
commit 8222c86355
2 changed files with 71 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
6ae2ae4fb436d95428ae53055a61a6d34c1c2354 Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "38fd1a37_90d499cb",
"filename": "doc/source/dist_cloud/kubernetes/distributed-cloud-ports-reference.rst",
"patchSetId": 1
},
"lineNbr": 117,
"author": {
"id": 26026
},
"writtenOn": "2024-04-24T11:16:07Z",
"side": 0,
"message": "Why did we remove these ?\n6443 is exposed on systemController and subclouds.",
"range": {
"startLine": 114,
"startChar": 0,
"endLine": 117,
"endChar": 222
},
"revId": "6ae2ae4fb436d95428ae53055a61a6d34c1c2354",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "baa1a538_38e8aa07",
"filename": "doc/source/dist_cloud/kubernetes/distributed-cloud-ports-reference.rst",
"patchSetId": 1
},
"lineNbr": 252,
"author": {
"id": 26026
},
"writtenOn": "2024-04-24T11:16:07Z",
"side": 0,
"message": "Did we remove these because Analyitics is not in starlingx ?\n\nIs this an upstream only change ?",
"range": {
"startLine": 235,
"startChar": 1,
"endLine": 252,
"endChar": 222
},
"revId": "6ae2ae4fb436d95428ae53055a61a6d34c1c2354",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
7988580b483b9a60d19bda9cf60b2191113fd386 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "45ff57b9_0fd62729",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 26026
},
"writtenOn": "2024-04-24T11:16:07Z",
"side": 1,
"message": "Why did we remove these ?\nNot",
"revId": "7988580b483b9a60d19bda9cf60b2191113fd386",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}