Update patch set 6

Patch Set 6: Workflow+1

(7 comments)

Patch-set: 6
Reviewer: Gerrit User 32852 <32852@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=+1, ec3ac86af3175f635ccabc3400471cd3746e3621
Attention: {"person_ident":"Gerrit User 32852 \u003c32852@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32852\u003e replied on the change"}
This commit is contained in:
Gerrit User 32852 2024-01-18 17:16:42 +00:00 committed by Gerrit Code Review
parent 60a980b0ea
commit 08b6e493d4
2 changed files with 133 additions and 0 deletions

View File

@ -0,0 +1,112 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "dbb0e4b4_505bd94a",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/static/dashboard/fault_management/active_alarms/active_alarms.controller.js",
"patchSetId": 4
},
"lineNbr": 48,
"author": {
"id": 32852
},
"writtenOn": "2024-01-18T17:16:42Z",
"side": 1,
"message": "trailing whitespace",
"revId": "23851052bb47aa2a113c425b64282e5b7d4bb5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e9a71336_6738b7f5",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/static/dashboard/fault_management/active_alarms/active_alarms.controller.js",
"patchSetId": 4
},
"lineNbr": 93,
"author": {
"id": 32852
},
"writtenOn": "2024-01-18T17:16:42Z",
"side": 1,
"message": "Please add a newline at end of file",
"revId": "23851052bb47aa2a113c425b64282e5b7d4bb5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "228510b3_a0f538f8",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/static/dashboard/fault_management/events/events.controller.js",
"patchSetId": 4
},
"lineNbr": 65,
"author": {
"id": 32852
},
"writtenOn": "2024-01-18T17:16:42Z",
"side": 1,
"message": "Trailing space",
"range": {
"startLine": 65,
"startChar": 0,
"endLine": 65,
"endChar": 3
},
"revId": "23851052bb47aa2a113c425b64282e5b7d4bb5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2f390b00_60c1ff73",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/static/dashboard/fault_management/events/events.controller.js",
"patchSetId": 4
},
"lineNbr": 94,
"author": {
"id": 32852
},
"writtenOn": "2024-01-18T17:16:42Z",
"side": 1,
"message": "Please add a newline at end of file",
"revId": "23851052bb47aa2a113c425b64282e5b7d4bb5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c204daaf_e538ab38",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/static/dashboard/fault_management/events_suppression/events_suppression.controller.js",
"patchSetId": 4
},
"lineNbr": 91,
"author": {
"id": 32852
},
"writtenOn": "2024-01-18T17:16:42Z",
"side": 1,
"message": "Please add a newline at end of file",
"revId": "23851052bb47aa2a113c425b64282e5b7d4bb5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "51b2c818_1d27f360",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/static/dashboard/fault_management/events_suppression/events_suppression.module.js",
"patchSetId": 4
},
"lineNbr": 134,
"author": {
"id": 32852
},
"writtenOn": "2024-01-18T17:16:42Z",
"side": 1,
"message": "Trailing whitespace",
"revId": "23851052bb47aa2a113c425b64282e5b7d4bb5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "79e7ada8_4174cfad",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 32852
},
"writtenOn": "2024-01-18T17:16:42Z",
"side": 1,
"message": "Code changes LGTM. Just minor comments regarding whitespaces.",
"revId": "e5c03e20c97719b5ddd024d49db18dea8869b0e1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}