starlingx
/
gui
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 28459 \u003c28459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28459\u003e replied on the change"}
This commit is contained in:
Gerrit User 28459 2024-01-04 14:09:44 +00:00 committed by Gerrit Code Review
parent fb0c7fd5a1
commit 31bf505e53
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
de5edc47cef0a3d6fc65b1b1e2ca750253f633c7
View File

@ -16,6 +16,23 @@
"message": "Hello. Can someone review that code? This is an approach to avoid having to send the name parameter when the subcloud is renamed from the UI with the new name being the same as the current one. \nThanks.",
"revId": "de5edc47cef0a3d6fc65b1b1e2ca750253f633c7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0143807a_a11f15ca",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/dc_admin/static/dashboard/dc_admin/cloud_overview/table/subcloud_table.controller.js",
"patchSetId": 1
},
"lineNbr": 391,
"author": {
"id": 28459
},
"writtenOn": "2024-01-04T14:09:44Z",
"side": 1,
"message": "Would the same problem happen with the other model fields (description, location, group_name)? Wondering if this should just be generalized to delete any unchanged field or if this is the only field that will cause a problem.",
"revId": "de5edc47cef0a3d6fc65b1b1e2ca750253f633c7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}