starlingx
/
gui
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(5 comments)

Patch-set: 3
Reviewer: Gerrit User 9926 <9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 28f85078c43acb471e67c9a31802e46459199edd
Attention: {"person_ident":"Gerrit User 34645 \u003c34645@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-01-22 20:05:03 +00:00 committed by Gerrit Code Review
parent 6a9e7bff52
commit 36554aa920
1 changed files with 115 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

115
8c4bbe87c0ee61e9f3d82de56005d686053cfe2c
View File

@ -16,6 +16,121 @@
"message": "Could you please take a look at this ?",
"revId": "8c4bbe87c0ee61e9f3d82de56005d686053cfe2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b3be68ca_3924015f",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/dc_admin/dc_orchestration/tabs.py",
"patchSetId": 3
},
"lineNbr": 2,
"author": {
"id": 9926
},
"writtenOn": "2024-01-22T20:05:03Z",
"side": 1,
"message": "2024\n\nseveral instances in this review",
"range": {
"startLine": 2,
"startChar": 21,
"endLine": 2,
"endChar": 26
},
"revId": "8c4bbe87c0ee61e9f3d82de56005d686053cfe2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7654bbeb_aab3c6b1",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/dc_admin/dc_orchestration/templates/dc_orchestration/_create_subcloud_strategy_config.html",
"patchSetId": 3
},
"lineNbr": 17,
"author": {
"id": 9926
},
"writtenOn": "2024-01-22T20:05:03Z",
"side": 1,
"message": "\u0027patch\u0027 is no longer applicable to full scope",
"range": {
"startLine": 17,
"startChar": 86,
"endLine": 17,
"endChar": 91
},
"revId": "8c4bbe87c0ee61e9f3d82de56005d686053cfe2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "52595327_715164d7",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/dc_admin/dc_orchestration/templates/dc_orchestration/_edit_subcloud_strategy_config.html",
"patchSetId": 3
},
"lineNbr": 6,
"author": {
"id": 9926
},
"writtenOn": "2024-01-22T20:05:03Z",
"side": 1,
"message": "needs update",
"range": {
"startLine": 6,
"startChar": 45,
"endLine": 6,
"endChar": 51
},
"revId": "8c4bbe87c0ee61e9f3d82de56005d686053cfe2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1141b86f_684ea20b",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/dc_admin/dc_orchestration/templates/dc_orchestration/_edit_subcloud_strategy_config.html",
"patchSetId": 3
},
"lineNbr": 17,
"author": {
"id": 9926
},
"writtenOn": "2024-01-22T20:05:03Z",
"side": 1,
"message": "needs update",
"range": {
"startLine": 17,
"startChar": 84,
"endLine": 17,
"endChar": 90
},
"revId": "8c4bbe87c0ee61e9f3d82de56005d686053cfe2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a3e15a66_415d94f6",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/dc_admin/dc_orchestration/views.py",
"patchSetId": 3
},
"lineNbr": 2,
"author": {
"id": 9926
},
"writtenOn": "2024-01-22T20:05:03Z",
"side": 1,
"message": "2024",
"range": {
"startLine": 2,
"startChar": 21,
"endLine": 2,
"endChar": 26
},
"revId": "8c4bbe87c0ee61e9f3d82de56005d686053cfe2c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}