starlingx
/
gui
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
This commit is contained in:
Gerrit User 35110 2023-11-03 14:51:55 +00:00 committed by Gerrit Code Review
parent e234b76590
commit 61742b5c72
1 changed files with 83 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

83
de1f9cee1890d8003b9059798cdf5c125315c7e8
View File

@ -47,6 +47,30 @@
"revId": "de1f9cee1890d8003b9059798cdf5c125315c7e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9da42de8_ef377881",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 7,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T14:51:55Z",
"side": 1,
"message": "Done",
"parentUuid": "2727d279_da4bc60a",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 80
},
"revId": "de1f9cee1890d8003b9059798cdf5c125315c7e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -64,6 +88,23 @@
"revId": "de1f9cee1890d8003b9059798cdf5c125315c7e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ade05d45_d30653df",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T14:51:55Z",
"side": 1,
"message": "recheck",
"revId": "de1f9cee1890d8003b9059798cdf5c125315c7e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +127,48 @@
},
"revId": "de1f9cee1890d8003b9059798cdf5c125315c7e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e6c6e1c5_69140bd5",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/software_management/forms.py",
"patchSetId": 4
},
"lineNbr": 2,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T14:51:55Z",
"side": 1,
"message": "Done",
"parentUuid": "5b319e56_1daf28b6",
"range": {
"startLine": 2,
"startChar": 16,
"endLine": 2,
"endChar": 25
},
"revId": "de1f9cee1890d8003b9059798cdf5c125315c7e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4c566c75_aa7ee9e9",
"filename": "starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/software_management/forms.py",
"patchSetId": 4
},
"lineNbr": 47,
"author": {
"id": 35110
},
"writtenOn": "2023-11-03T14:51:55Z",
"side": 1,
"message": "\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.",
"parentUuid": "1b1031d7_9bc67636",
"revId": "de1f9cee1890d8003b9059798cdf5c125315c7e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}