From 827e89c04a386677ff597cfd799353d6c856bf74 Mon Sep 17 00:00:00 2001 From: Eric Barrett Date: Mon, 18 Mar 2019 10:49:48 -0400 Subject: [PATCH] Enable Signature Differs Warning in pylint Pylint currently ignores any signature differs (W0222) warnings Enable it for more thorough testing of code Change-Id: Iddb8734eb70e9e099d50ba0e458190053a8cd51b Signed-off-by: Eric Barrett --- pylint.rc | 5 ++--- .../dashboards/admin/inventory/storages/lvg_params/views.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pylint.rc b/pylint.rc index 0368d4c5..b2bbf8f1 100755 --- a/pylint.rc +++ b/pylint.rc @@ -29,7 +29,6 @@ load-plugins= # W0201 attribute-defined-outside-init # W0212 protected-access var starting with _ used outside class or descendant # W0221 arguments-differ -# W0222 signature-differs # W0235 useless-super-delegation # W0403 relative-import warning # W0511 fixme @@ -37,8 +36,8 @@ load-plugins= # W0703 broad except warning # E0202 method-hidden # E0203 access-member-before-definition -# E1101 no-member -disable=C, R, W0201, W0212, W0221, W0222, W0235, W0403, W0511, W0613, W0703, +# E1101 no-member +disable=C, R, W0201, W0212, W0221, W0235, W0403, W0511, W0613, W0703, E0202, E0203, E1101 diff --git a/starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/inventory/storages/lvg_params/views.py b/starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/inventory/storages/lvg_params/views.py index a6c97378..b352ba44 100644 --- a/starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/inventory/storages/lvg_params/views.py +++ b/starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/inventory/storages/lvg_params/views.py @@ -23,7 +23,7 @@ class EditView(forms.ModalFormView): template_name = 'admin/inventory/storages/lvg/edit.html' success_url = 'horizon:admin:inventory:localvolumegroupdetail' - def get_form(self, form_class): + def get_form(self, form_class=None): self.form = super(EditView, self).get_form(form_class) return self.form