starlingx
/
ha
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 35741 \u003c35741@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35741\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35741\u003e replied on the change"}
This commit is contained in:
Gerrit User 35741 2024-01-15 17:33:07 +00:00 committed by Gerrit Code Review
parent 46f862037d
commit 0aa52820fd
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
bb8a9cd1bc1e04fd18e0bd8e55a2fed2e0c2bb8b
View File

@ -16,6 +16,24 @@
"message": "is the mirror required, i.e. on \u0027disable\u0027 action ?",
"revId": "bb8a9cd1bc1e04fd18e0bd8e55a2fed2e0c2bb8b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d05b06a5_2fa99b75",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 2
},
"lineNbr": 171,
"author": {
"id": 35741
},
"writtenOn": "2024-01-15T17:33:07Z",
"side": 1,
"message": "I don\u0027t believe its needed. but since it has been brought up twice in the code inspection . It won\u0027t hurt to add the mirror/reverse/disable dependancy",
"parentUuid": "70c514e6_4a62f8a3",
"revId": "bb8a9cd1bc1e04fd18e0bd8e55a2fed2e0c2bb8b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}