starlingx
/
ha
Code Issues Proposed changes

Update patch set 8 

Patch Set 8: Code-Review+1

(1 comment)

Patch-set: 8
Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 31b5f48029d1c075d12010a7bc373e0d64db0da3
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
This commit is contained in:
Gerrit User 28464 2024-02-26 17:11:29 +00:00 committed by Gerrit Code Review
parent 57c4b5c72a
commit 2bdc84a973
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
a63ea17c1b4ad07488b14384ce8f761032a913fe
View File

@ -16,6 +16,29 @@
"message": "as discussed, the potential patching issues will be handled in separated user story.",
"revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "db6d1189_62f82b4b",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 8
},
"lineNbr": 461,
"author": {
"id": 28464
},
"writtenOn": "2024-02-26T17:11:29Z",
"side": 1,
"message": "Does importing python modules declared in a function meet our coding standard ? I thought we were required to put all imports at the top of the file in alphabetical order.",
"range": {
"startLine": 459,
"startChar": 8,
"endLine": 461,
"endChar": 61
},
"revId": "a63ea17c1b4ad07488b14384ce8f761032a913fe",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}