starlingx
/
ha
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 35022 \u003c35022@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28466 \u003c28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
This commit is contained in:
Gerrit User 28466 2023-10-25 18:47:19 +00:00 committed by Gerrit Code Review
parent cf90145170
commit 3e062b68fa
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
28e3b5d5af870231d0f43d62f26c4a6ebe8abc30
View File

@ -64,6 +64,30 @@
"revId": "28e3b5d5af870231d0f43d62f26c4a6ebe8abc30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e01c8660_2dfb31db",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 4
},
"lineNbr": 223,
"author": {
"id": 28466
},
"writtenOn": "2023-10-25T18:47:19Z",
"side": 1,
"message": "Thanks for the information. I think we should have dependency from the services such as keystone, barbican to BOTH rabbit and dnsmasq, so that they start only after both dnsmasq and rabbit both up. by having dnsmasq depends on rabbit, dnsmasq and rabbit will be started sequentially (which is unnecessary), and all other services depend on dnsmasq will be delayed to start unnecessarily.",
"parentUuid": "c5da7a90_ebbfa8ee",
"range": {
"startLine": 223,
"startChar": 0,
"endLine": 223,
"endChar": 107
},
"revId": "28e3b5d5af870231d0f43d62f26c4a6ebe8abc30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -158,6 +182,30 @@
},
"revId": "28e3b5d5af870231d0f43d62f26c4a6ebe8abc30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "33385e95_2f445436",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 4
},
"lineNbr": 237,
"author": {
"id": 28466
},
"writtenOn": "2023-10-25T18:47:19Z",
"side": 1,
"message": "make sense. thanks for the info.",
"parentUuid": "12722ca3_d253ca61",
"range": {
"startLine": 237,
"startChar": 0,
"endLine": 237,
"endChar": 112
},
"revId": "28e3b5d5af870231d0f43d62f26c4a6ebe8abc30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}