starlingx
/
ha
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(4 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34895 \u003c34895@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"}
This commit is contained in:
Gerrit User 33390 2024-02-22 15:23:32 +00:00 committed by Gerrit Code Review
parent 3b035d47e2
commit 61716c7035
1 changed files with 92 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

92
ba1f1cd71ac149d6821b921ef2220894e8baed0d
View File

@ -16,6 +16,98 @@
"message": "recheck",
"revId": "ba1f1cd71ac149d6821b921ef2220894e8baed0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1948eb5c_0a57565a",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 6
},
"lineNbr": 36,
"author": {
"id": 33390
},
"writtenOn": "2024-02-22T15:23:32Z",
"side": 1,
"message": "nit: out of alphabetical order",
"range": {
"startLine": 36,
"startChar": 0,
"endLine": 36,
"endChar": 39
},
"revId": "ba1f1cd71ac149d6821b921ef2220894e8baed0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b0b92d25_2b8fe92b",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 6
},
"lineNbr": 456,
"author": {
"id": 33390
},
"writtenOn": "2024-02-22T15:23:32Z",
"side": 1,
"message": "nit: should be `:param \u003cname\u003e:`",
"range": {
"startLine": 455,
"startChar": 8,
"endLine": 456,
"endChar": 39
},
"revId": "ba1f1cd71ac149d6821b921ef2220894e8baed0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ef5b981c_ec609446",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 6
},
"lineNbr": 459,
"author": {
"id": 33390
},
"writtenOn": "2024-02-22T15:23:32Z",
"side": 1,
"message": "This help text doesn\u0027t really help the user.",
"range": {
"startLine": 459,
"startChar": 22,
"endLine": 459,
"endChar": 30
},
"revId": "ba1f1cd71ac149d6821b921ef2220894e8baed0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "542b5156_f5828573",
"filename": "service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py",
"patchSetId": 6
},
"lineNbr": 498,
"author": {
"id": 33390
},
"writtenOn": "2024-02-22T15:23:32Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 498,
"startChar": 22,
"endLine": 498,
"endChar": 37
},
"revId": "ba1f1cd71ac149d6821b921ef2220894e8baed0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}