diff --git a/pylint.rc b/pylint.rc new file mode 100755 index 00000000..a49914c8 --- /dev/null +++ b/pylint.rc @@ -0,0 +1,256 @@ +[MASTER] +# Specify a configuration file. +rcfile=pylint.rc + +# Python code to execute, usually for sys.path manipulation such as pygtk.require(). +#init-hook= + +# Add files or directories to the blacklist. They should be base names, not paths. +ignore=moxstubout.py,mockpatch.py + +# Pickle collected data for later comparisons. +persistent=yes + +# List of plugins (as comma separated values of python modules names) to load, +# usually to register additional checkers. +load-plugins= + + +[MESSAGES CONTROL] +# Enable the message, report, category or checker with the given id(s). You can +# either give multiple identifier separated by comma (,) or put this option +# multiple time. +#enable= + +# Disable the message, report, category or checker with the given id(s). You +# can either give multiple identifier separated by comma (,) or put this option +# multiple time (only on the command line, not in the configuration file where +# it should appear only once). +# W0102 dangerous-default-value +# W0107 unnecessary-pass +# W0110 deprecated-lambda +# W0120 useless-else-on-loop +# W0201 attribute-defined-outside-init +# W0212 protected-access +# W0221 arguments-differ +# W0223 abstract-method +# W0231 super-init-not-called +# W0235 useless-super-delegation +# W0402 deprecated-module +# W0403 relative-import +# W0511 fixme +# W0603 global-statement +# W0611 unused-import +# W0612 unused-variable +# W0613 unused-argument +# W0621 redefined-outer-name +# W0622 redefined-builtin +# W0702 bare-except +# W0703 broad except warning +# W1113 keyword-arg-before-vararg +# W1201 logging-not-lazy +# W1401 anomalous-backslash-in-string +# +# The following are errors which should be fixed +# +# method-hidden (E0202) +# access-member-before-definition (E0203) +# undefined-variable (E0602) +# invalid-all-object (E0604) +# no-name-in-module (E0611) +# raising-bad-type (E0702) +# notimplemented-raised (E0711) +# bad-super-call (E1003) +# no-member (E1101) +# not-callable (E1102) +# too-many-function-args (E1121) +# unsubscriptable-object (E1136) +disable=C, R, + W0102, W0107, W0110, W0120, W0201, W0212, W0221, W0223, W0231, W0235, W0402, W0403, + W0511, W0603, W0611, W0612, W0613, W0621, W0622, W0702, W0703, W1113, W1201, W1401, + E0202, E0203, E0602, E0604, E0611, E0702, E0711, E1003, E1101, E1102, E1121, E1136 + + + +[REPORTS] +# Set the output format. Available formats are text, parseable, colorized, msvs +# (visual studio) and html +output-format=text + +# Put messages in a separate file for each module / package specified on the +# command line instead of printing them on stdout. Reports (if any) will be +# written in a file name "pylint_global.[txt|html]". +files-output=no + +# Tells whether to display a full report or only the messages +reports=no + +# Python expression which should return a note less than 10 (10 is the highest +# note). You have access to the variables errors warning, statement which +# respectively contain the number of errors / warnings messages and the total +# number of statements analyzed. This is used by the global evaluation report +# (RP0004). +evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) + + +[SIMILARITIES] +# Minimum lines number of a similarity. +min-similarity-lines=4 + +# Ignore comments when computing similarities. +ignore-comments=yes + +# Ignore docstrings when computing similarities. +ignore-docstrings=yes + + +[FORMAT] +# Maximum number of characters on a single line. +max-line-length=85 + +# Maximum number of lines in a module +max-module-lines=1000 + +# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 tab). +indent-string=' ' + + +[TYPECHECK] +# Tells whether missing members accessed in mixin class should be ignored. A +# mixin class is detected if its name ends with "mixin" (case insensitive). +ignore-mixin-members=yes + +# List of classes names for which member attributes should not be checked +# (useful for classes with attributes dynamically set). +ignored-classes=SQLObject,sqlalchemy,scoped_session,_socketobject,PeriodicTasks,Collection,APIBase + +# List of members which are set dynamically and missed by pylint inference +# system, and so shouldn't trigger E0201 when accessed. Python regular +# expressions are accepted. +#generated-members=REQUEST,acl_users,aq_parent +generated-members=uuid + + +[BASIC] +# List of builtins function names that should not be used, separated by a comma +bad-functions=map,filter,apply,input + +# Regular expression which should only match correct module names +module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ + +# Regular expression which should only match correct module level names +const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$ + +# Regular expression which should only match correct class names +class-rgx=[A-Z_][a-zA-Z0-9]+$ + +# Regular expression which should only match correct function names +function-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct method names +method-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct instance attribute names +attr-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct argument names +argument-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct variable names +variable-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct list comprehension / +# generator expression variable names +inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ + +# Good variable names which should always be accepted, separated by a comma +good-names=i,j,k,ex,Run,_ + +# Bad variable names which should always be refused, separated by a comma +bad-names=foo,bar,baz,toto,tutu,tata + +# Regular expression which should only match functions or classes name which do +# not require a docstring +no-docstring-rgx=__.*__ + + +[MISCELLANEOUS] +# List of note tags to take in consideration, separated by a comma. +notes=FIXME,XXX,TODO + + +[VARIABLES] +# Tells whether we should check for unused import in __init__ files. +init-import=no + +# A regular expression matching the beginning of the name of dummy variables +# (i.e. not used). +dummy-variables-rgx=_|dummy + +# List of additional names supposed to be defined in builtins. Remember that +# you should avoid to define new builtins when possible. +additional-builtins= + + +[IMPORTS] +# Deprecated modules which should not be used, separated by a comma +deprecated-modules=regsub,string,TERMIOS,Bastion,rexec + +# Create a graph of every (i.e. internal and external) dependencies in the +# given file (report RP0402 must not be disabled) +import-graph= + +# Create a graph of external dependencies in the given file (report RP0402 must +# not be disabled) +ext-import-graph= + +# Create a graph of internal dependencies in the given file (report RP0402 must +# not be disabled) +int-import-graph= + + +[DESIGN] +# Maximum number of arguments for function / method +max-args=5 + +# Argument names that match this expression will be ignored. Default to name +# with leading underscore +ignored-argument-names=_.* + +# Maximum number of locals for function / method body +max-locals=15 + +# Maximum number of return / yield for function / method body +max-returns=6 + +# Maximum number of branch for function / method body +max-branchs=12 + +# Maximum number of statements in function / method body +max-statements=50 + +# Maximum number of parents for a class (see R0901). +max-parents=7 + +# Maximum number of attributes for a class (see R0902). +max-attributes=7 + +# Minimum number of public methods for a class (see R0903). +min-public-methods=2 + +# Maximum number of public methods for a class (see R0904). +max-public-methods=20 + + +[CLASSES] +# List of method names used to declare (i.e. assign) instance attributes. +defining-attr-methods=__init__,__new__,setUp + +# List of valid names for the first argument in a class method. +valid-classmethod-first-arg=cls + + +[EXCEPTIONS] +# Exceptions that will emit a warning when being caught. Defaults to +# "Exception" +overgeneral-exceptions=Exception diff --git a/service-mgmt-api/sm-api/sm_api/db/sqlalchemy/migration.py b/service-mgmt-api/sm-api/sm_api/db/sqlalchemy/migration.py index c76f4d79..b7f2816a 100644 --- a/service-mgmt-api/sm-api/sm_api/db/sqlalchemy/migration.py +++ b/service-mgmt-api/sm-api/sm_api/db/sqlalchemy/migration.py @@ -20,7 +20,7 @@ # -import distutils.version as dist_version +import distutils.version as dist_version # pylint: disable=import-error import os import migrate diff --git a/service-mgmt-api/sm-api/sm_api/openstack/common/lockutils.py b/service-mgmt-api/sm-api/sm_api/openstack/common/lockutils.py index 98c3bfe8..bccc48ee 100644 --- a/service-mgmt-api/sm-api/sm_api/openstack/common/lockutils.py +++ b/service-mgmt-api/sm-api/sm_api/openstack/common/lockutils.py @@ -130,7 +130,7 @@ class _PosixLock(_InterProcessLock): if os.name == 'nt': - import msvcrt + import msvcrt # pylint: disable=import-error InterProcessLock = _WindowsLock else: import fcntl diff --git a/tox.ini b/tox.ini index 46f34bee..40dc8106 100644 --- a/tox.ini +++ b/tox.ini @@ -14,6 +14,23 @@ deps = -r{toxinidir}/test-requirements.txt whitelist_externals = reno [testenv:linters] +basepython=python2.7 +deps = {[testenv]deps} + eventlet + httplib2 + iso8601 + jsonpatch + keystonemiddleware + kombu + MySQL-python + oslo.config + pecan + prettytable + psutil + sqlalchemy + sqlalchemy-migrate + wsme + pylint whitelist_externals = bash commands = bash -c "find {toxinidir} \ @@ -28,6 +45,10 @@ commands = -o \( -name .tox -prune \) \ -o -type f -name '*.yaml' \ -print0 | xargs -0 yamllint" + pylint --rcfile=./pylint.rc --extension-pkg-whitelist=greenlet \ + ./service-mgmt-api/sm-api/sm_api/ \ + ./service-mgmt-tools/sm-tools/sm_tools/ \ + ./service-mgmt-client/sm-client/sm_client/ [flake8] # The following are being suppressed for now @@ -90,7 +111,6 @@ commands = # B006 Do not use mutable data structures for argument defaults. (python3) # B007 Loop control variable 'key' not used within the loop body. If this is intended, start the name with an underscore. # B008 Do not perform calls in argument defaults. The call is performed only once at function definition time. -# B301 Python 3 does not include `.iter*` methods on dictionaries. # B303 `__metaclass__` does nothing on Python 3. For Python 2 compatibility, use `six.add_metaclass`. # B305 `.next()` is not a thing on Python 3. Use the `next()` builtin. For Python 2 compatibility, use `six.next()`. # B306 `BaseException.message` has been deprecated as of Python 2.6 and is removed in Python 3. @@ -99,7 +119,7 @@ ignore= E114,E116,E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E201,E228,E2 H102,H104,H105,H106,H201,H231,H233,H236,H306,H401,H403,H404,H405,H501, W291,W292,W391,W503,W601, F401,F811,F821,F841, - B001,B004,B006,B007,B008,B301,B303,B305,B306 + B001,B004,B006,B007,B008,B303,B305,B306 # Enable checks which are off by default # H106 Don’t put vim configuration in source files (off by default). SHOULD BE ENABLED. # H203 Use assertIs(Not)None to check for None (off by default). @@ -107,7 +127,6 @@ ignore= E114,E116,E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E201,E228,E2 enable-extensions = H203 max-line-length = 110 - [testenv:pep8] usedevelop = False skip_install = True