starlingx
/
ha
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 28676 \u003c28676@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28676\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35603 \u003c35603@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28676\u003e replied on the change"}
This commit is contained in:
Gerrit User 28676 2024-04-26 13:28:13 +00:00 committed by Gerrit Code Review
parent 5eee245fa7
commit 73c909f156
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
9a44c1deecacd450cbd117b2d6d21c180176110e Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "bb42b220_8713980a",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 3
},
"lineNbr": 49,
"author": {
"id": 28676
},
"writtenOn": "2024-04-26T13:28:13Z",
"side": 1,
"message": "It shouldn\u0027t be added this way, it should be as the following example:\n\nINSERT INTO \"SERVICE_GROUP_MEMBERS\" SELECT MAX(id) + 1,\u0027no\u0027,\u0027controller-services\u0027,\u0027drbd-etcd\u0027,\u0027critical\u0027 FROM \"SERVICE_GROUP_MEMBERS\";",
"revId": "9a44c1deecacd450cbd117b2d6d21c180176110e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "898be1ab_5254a6d8",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 3
},
"lineNbr": 138,
"author": {
"id": 28676
},
"writtenOn": "2024-04-26T13:28:13Z",
"side": 1,
"message": "I think we shouldn\u0027t add this service as \"66\", it should be added as the following example:\n\nINSERT INTO \"SERVICES\" SELECT MAX(id) + 1,\u0027no\u0027,\u0027drbd-etcd\u0027,\u0027initial\u0027,\u0027initial\u0027,\u0027none\u0027,\u0027none\u0027,2,1,90000,4,16,\u0027\u0027 FROM \"SERVICES\";",
"revId": "9a44c1deecacd450cbd117b2d6d21c180176110e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}