starlingx
/
ha
Code Issues Proposed changes

Update patch set 9 

Patch Set 9: Code-Review+2 Workflow+1

(1 comment)

Patch-set: 9
Reviewer: Gerrit User 28466 <28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, e0051b43b7c36a67953b59a3df15598a91c15961
Label: Workflow=+1, 3ec95a80da57da1cc3b8582d4cecaf090a3ea7d8
Attention: {"person_ident":"Gerrit User 32933 \u003c32933@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28466 \u003c28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
This commit is contained in:
Gerrit User 28466 2024-04-25 18:14:52 +00:00 committed by Gerrit Code Review
parent dd1a392fb6
commit 8685ba8c69
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
64278ce1e655e0560670536ecfb7af95f3321acd
View File

@ -88,6 +88,24 @@
"parentUuid": "67ffeee5_a0cd8aff",
"revId": "64278ce1e655e0560670536ecfb7af95f3321acd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5da71d71_54581059",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 28466
},
"writtenOn": "2024-04-25T18:14:52Z",
"side": 1,
"message": "I do not see the dependency to show the concert of primary and secondary stack. \nhttps://review.opendev.org/c/starlingx/ha/+/912418/9/service-mgmt/sm-db/database/create_sm_db.sql#191 and Line 187 set the same dependency to both ipv6 and ipv4 in order for drbd-rabbit service to go active.\nI am fine with the current implementation as long as we understand the potential impact for the \"AND\" relation w/ service dependency.\nThanks for the reply.",
"parentUuid": "e5187927_d1df9c45",
"revId": "64278ce1e655e0560670536ecfb7af95f3321acd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}