starlingx
/
ha
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 35022 <35022@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, d71f13ab92e3d08ed0eae0254d331e0bbad51626
Attention: {"person_ident":"Gerrit User 35022 \u003c35022@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35022\u003e replied on the change"}
This commit is contained in:
Gerrit User 35022 2024-01-12 17:10:48 +00:00 committed by Gerrit Code Review
parent daa7bb47f0
commit e29a459a48
1 changed files with 51 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
ba7929d90721ceccda51faed2886c5952595fb9d
View File

@ -22,6 +22,57 @@
},
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "aad3230f_3bb2f861",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 1
},
"lineNbr": 171,
"author": {
"id": 35022
},
"writtenOn": "2024-01-12T17:10:48Z",
"side": 1,
"message": "It is necessary to create the dependency for the disable",
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9e9eae0b_e6566fef",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 1
},
"lineNbr": 210,
"author": {
"id": 35022
},
"writtenOn": "2024-01-12T17:10:48Z",
"side": 1,
"message": "I believe you need to add here the dependency that to disable the dnsmasq, the haproxy need to be disabled too.",
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ec5b5763_539bb2a2",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 1
},
"lineNbr": 210,
"author": {
"id": 35022
},
"writtenOn": "2024-01-12T17:10:48Z",
"side": 1,
"message": "like the oam-ip depends that haproxy is disabled in order to be disabled too, \nI believe you need to add here the same dependency to disable the dnsmasq.",
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}