Update patch set 2

Patch Set 2:

(2 comments)

Patch-set: 2
CC: Gerrit User 28676 <28676@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 35603 \u003c35603@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28676\u003e replied on the change"}
This commit is contained in:
Gerrit User 28676 2024-04-24 14:23:51 +00:00 committed by Gerrit Code Review
parent e366529e7e
commit fb6d8ba74d
1 changed files with 44 additions and 0 deletions

View File

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "d255312c_ec455e73",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 2
},
"lineNbr": 217,
"author": {
"id": 28676
},
"writtenOn": "2024-04-24T14:23:51Z",
"side": 1,
"message": "There should be two dependencies rule in this table, the missing one is:\n\nipsec-config should depend on management-ip for enable action (ie, it starts after management-ip is started)\n\n(I think the one we have here is right, which is, ipsec-config should depend on management-ip for disable action, ie, stops after management-ip is stopped. This rule is different from other services. We need test to confirm this is right.).",
"range": {
"startLine": 217,
"startChar": 0,
"endLine": 217,
"endChar": 119
},
"revId": "562c7faf5a0a8a4c85ded1ce13ef232a1da52956",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5ac9c887_7dda32e0",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 2
},
"lineNbr": 604,
"author": {
"id": 28676
},
"writtenOn": "2024-04-24T14:23:51Z",
"side": 1,
"message": "We need \"audit-enabled\" and \"audit-disabled\" actions.",
"revId": "562c7faf5a0a8a4c85ded1ce13ef232a1da52956",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}