ha/64278ce1e655e0560670536ecfb7af95f3321acd

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "73b47690_a4fe8be6",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 9
      },
      "lineNbr": 0,
      "author": {
        "id": 28466
      },
      "writtenOn": "2024-04-25T14:17:11Z",
      "side": 1,
      "message": "A question in general, by adding dual-stack, a service that uses to depend on an ip service now depends on both ipv4 and ipv6 services to \"go-active\", this could compromise the availability of the dependent services therefore degrade the availability of the system. Do we always require both ipv4 and ipv6 to be available? or would it work for example when ipv6 is down, but ipv4 is still available?",
      "revId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "28d90bf6_be31464b",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 9
      },
      "lineNbr": 0,
      "author": {
        "id": 32933
      },
      "writtenOn": "2024-04-25T14:28:10Z",
      "side": 1,
      "message": "we do not require both to be available, since it will be possible to have a system to be single-stack",
      "parentUuid": "73b47690_a4fe8be6",
      "revId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e17381d9_93018f5b",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 9
      },
      "lineNbr": 0,
      "author": {
        "id": 28466
      },
      "writtenOn": "2024-04-25T15:48:40Z",
      "side": 1,
      "message": "In an environment that dual-stack is configured, should the system be functioning w/ only either ipv4 or ipv6 is working properly or it requires both stacks to be functioning?",
      "parentUuid": "28d90bf6_be31464b",
      "revId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "67ffeee5_a0cd8aff",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 9
      },
      "lineNbr": 0,
      "author": {
        "id": 28466
      },
      "writtenOn": "2024-04-25T15:52:10Z",
      "side": 1,
      "message": "for example, my understanding is that if both ipv4 and ipv6 are configured, the system should still work if ipv6 is down, while ipv4 is available, or vice versa.",
      "parentUuid": "e17381d9_93018f5b",
      "revId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e5187927_d1df9c45",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 9
      },
      "lineNbr": 0,
      "author": {
        "id": 32933
      },
      "writtenOn": "2024-04-25T16:34:41Z",
      "side": 1,
      "message": "there is a concept of primary and secondary, internal operations run over the primary, and they do not fall back to the secondary unless the application/service is prepared to do so.\n\nThe loss of the primary would have the same impact as it has today, its loss will create the same set of problems.",
      "parentUuid": "67ffeee5_a0cd8aff",
      "revId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5da71d71_54581059",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 9
      },
      "lineNbr": 0,
      "author": {
        "id": 28466
      },
      "writtenOn": "2024-04-25T18:14:52Z",
      "side": 1,
      "message": "I do not see the dependency to show the concert of primary and secondary stack. \nhttps://review.opendev.org/c/starlingx/ha/+/912418/9/service-mgmt/sm-db/database/create_sm_db.sql#191 and Line 187 set the same dependency to both ipv6 and ipv4 in order for drbd-rabbit service to go active.\nI am fine with the current implementation as long as we understand the potential impact for the \"AND\" relation w/ service dependency.\nThanks for the reply.",
      "parentUuid": "e5187927_d1df9c45",
      "revId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ],
  "submitRequirementResults": [
    {
      "submitRequirement": {
        "name": "Code-Review",
        "description": {
          "value": "Code reviewed by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": true
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Verified",
        "description": {
          "value": "Verified in gate by CI"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Workflow",
        "description": {
          "value": "Approved for gate by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MAX"],"failingAtoms":["label:Workflow=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "64278ce1e655e0560670536ecfb7af95f3321acd",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    }
  ]
}