starlingx
/
integ
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(4 comments)

Patch-set: 7
Reviewer: Gerrit User 28715 <28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 72338ab54b0b307c298c2387c8353544d162367c
Attention: {"person_ident":"Gerrit User 28715 \u003c28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28715\u003e replied on the change"}
This commit is contained in:
Gerrit User 28715 2024-04-23 12:11:43 +00:00 committed by Gerrit Code Review
parent 208c835e6b
commit 00031d41e3
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
a39b06d3a491a0d5281b21e648df6ce5ef1378f1 Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "407e3eb5_64b9442d",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 8,
"author": {
"id": 28715
},
"writtenOn": "2024-04-23T12:11:43Z",
"side": 1,
"message": "Thinking it would be easier to understand this at high level if we to explain something like....\n\nPods with namespace \u0027kube-system\u0027, or labeled with \u0027app.starlingx.io/component\u003dplatform\u0027 are identified as \u0027platform\u0027. These have isolated cpu affinity cpuset when kubelet cpu-manager \u0027static\u0027 policy is configured. This decouples performance of application pods from the platform.\n\nThinking something like this needs to be put in the specific patch too, since the message is missing the new platform check criteria.",
"revId": "a39b06d3a491a0d5281b21e648df6ce5ef1378f1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "71f38425_5786b967",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 22,
"author": {
"id": 28715
},
"writtenOn": "2024-04-23T12:11:43Z",
"side": 1,
"message": "Split sentence here.",
"range": {
"startLine": 22,
"startChar": 39,
"endLine": 22,
"endChar": 44
},
"revId": "a39b06d3a491a0d5281b21e648df6ce5ef1378f1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d3f7a7f4_fff23cd3",
"filename": "kubernetes/kubernetes-1.26.1/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 7
},
"lineNbr": 9,
"author": {
"id": 28715
},
"writtenOn": "2024-04-23T12:11:43Z",
"side": 1,
"message": "Should update this now that we have changed the actual criteria for platform pod.\n\neg.,something like:\nPods with namespace \u0027kube-system\u0027, or labeled with \u0027app.starlingx.io/component\u003dplatform\u0027 are identified as \u0027platform\u0027. These have isolated cpu affinity cpuset when cpu-manager \u0027static\u0027 policy is configured.",
"range": {
"startLine": 6,
"startChar": 0,
"endLine": 9,
"endChar": 32
},
"revId": "a39b06d3a491a0d5281b21e648df6ce5ef1378f1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e3654c65_a0be8144",
"filename": "kubernetes/kubernetes-1.26.1/debian/deb_folder/patches/Identify-platform-pods-based-on-pod-or-namespace-labels.patch",
"patchSetId": 7
},
"lineNbr": 139,
"author": {
"id": 28715
},
"writtenOn": "2024-04-23T12:11:43Z",
"side": 1,
"message": "this log is inconsistent with the check",
"range": {
"startLine": 137,
"startChar": 0,
"endLine": 139,
"endChar": 3
},
"revId": "a39b06d3a491a0d5281b21e648df6ce5ef1378f1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}