Update patch set 8
Patch Set 8: Code-Review-1 (2 comments) Patch-set: 8 Reviewer: Gerrit User 28715 <28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 6ac19c463f4015052801aac9696187b489142532 Attention: {"person_ident":"Gerrit User 28715 \u003c28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28715\u003e replied on the change"}
This commit is contained in:
parent
e61602998e
commit
007f63e7cd
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c18b1b3b_178e7cf3",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 25,
|
||||
"author": {
|
||||
"id": 28715
|
||||
},
|
||||
"writtenOn": "2024-04-25T20:43:54Z",
|
||||
"side": 1,
|
||||
"message": "Condense/simplify these 2 paragraphs.. it is wordy and partly repeating what you already have said. Something like:\n\nThe new patch Identify-platform-pods-based-on-pod-or-namespace-labels.patch is used to identify platform pods using above criteria for Kubernetes 1.25 and later. The hard-coded list of platform namespaces is no longer required. The original hard-coded list is still kept for Kubernetes 1.24 so we can phase in this change.",
|
||||
"range": {
|
||||
"startLine": 15,
|
||||
"startChar": 0,
|
||||
"endLine": 25,
|
||||
"endChar": 40
|
||||
},
|
||||
"revId": "1542fdea18f4b17cf9dee2987c6ae628fdea62db",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "815fae85_844fdfc9",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 42,
|
||||
"author": {
|
||||
"id": 28715
|
||||
},
|
||||
"writtenOn": "2024-04-25T20:43:54Z",
|
||||
"side": 1,
|
||||
"message": "You have actually done more Testcases here relating to:\n- verify correct cpuset affinity of platform vs application pods after host lock/unlock\n- verify kube-system namespace pods are correctly identified as Platform",
|
||||
"revId": "1542fdea18f4b17cf9dee2987c6ae628fdea62db",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue