starlingx
/
integ
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 24777 \u003c24777@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36411\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36411 \u003c36411@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36411\u003e replied on the change"}
This commit is contained in:
Gerrit User 36411 2024-04-22 14:28:58 +00:00 committed by Gerrit Code Review
parent 02cb887f9b
commit 0d070b8b54
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
bd90e442ac4aa8b5caa5825e873ed0e188b7eb05
View File

@ -16,6 +16,24 @@
"message": "I think this code looks fine, and your testing worked:: but I wonder if we need to add something under https://opendev.org/starlingx/apt-ostree/src/branch/master/config/starlingx/bootstrap.yaml#L293 ?\n\nI\u0027m honestly not sure (just looking at other puppet modules stx creates debian packages for), but I\u0027d like to remove my +2 before the weekend",
"revId": "bd90e442ac4aa8b5caa5825e873ed0e188b7eb05",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "42cf6075_b3850e9c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 36411
},
"writtenOn": "2024-04-22T14:28:58Z",
"side": 1,
"message": "I don\u0027t see similar package puppet-zitrlp-strongswan on this file too. Not sure relevant or not though.",
"parentUuid": "00c86283_0933c4aa",
"revId": "bd90e442ac4aa8b5caa5825e873ed0e188b7eb05",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}