starlingx
/
integ
Code Issues Proposed changes

Update patch set 19 

Patch Set 19:

(2 comments)

Patch-set: 19
Attention: {"person_ident":"Gerrit User 35757 \u003c35757@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35296\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36077 \u003c36077@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35296\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 30539 \u003c30539@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35296\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28715 \u003c28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35296\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35296 \u003c35296@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35296\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28656 \u003c28656@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35296\u003e replied on the change"}
This commit is contained in:
Gerrit User 35296 2024-04-01 15:47:07 +00:00 committed by Gerrit Code Review
parent f7960b97f9
commit 3ed642fe6a
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
8fb7e782971d37e400a2e2d4fd4941f57ae7a469
View File

@ -50,6 +50,24 @@
"message": "If this was not intended to merge but is finalized, please make a note here and we\u0027ll go ahead with the docs merges.",
"revId": "8fb7e782971d37e400a2e2d4fd4941f57ae7a469",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c4630789_b160a278",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 19
},
"lineNbr": 0,
"author": {
"id": 35296
},
"writtenOn": "2024-04-01T15:47:07Z",
"side": 1,
"message": "This particular change will not be merged in the code base, I have raised \nthis review just so that the cores can agree on the list of images and the script\nthat will be used to execute manually to delete images before \nperforming platform upgrade.",
"parentUuid": "ef73e823_29d135f8",
"revId": "8fb7e782971d37e400a2e2d4fd4941f57ae7a469",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

24
c167690dc0fb2d2b83f120252313723a1d2e6267
View File

@ -40,6 +40,30 @@
"revId": "c167690dc0fb2d2b83f120252313723a1d2e6267",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fa6a4034_5d8875cc",
"filename": "remove_unused_platform_image.sh",
"patchSetId": 18
},
"lineNbr": 27,
"author": {
"id": 35296
},
"writtenOn": "2024-04-01T15:47:07Z",
"side": 1,
"message": "Done",
"parentUuid": "7e4d97f1_409ffcc1",
"range": {
"startLine": 27,
"startChar": 0,
"endLine": 27,
"endChar": 43
},
"revId": "c167690dc0fb2d2b83f120252313723a1d2e6267",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {