From 64209754962600178cf07323356e678633687435 Mon Sep 17 00:00:00 2001
From: albailey <Al.Bailey@windriver.com>
Date: Thu, 4 Nov 2021 09:36:33 -0500
Subject: [PATCH] Updating the pylint tox target to reflect its targets

pylint is currently only running on storage_topology
however it was using generic dependencies and installing
and suppressing far more than it needed to.

This will get pylint to pass zuul as well, since some
of the un-needed dependencies are failing to install.

Story: 2008943
Task: 43850
Signed-off-by: albailey <Al.Bailey@windriver.com>
Change-Id: I250754ca8f4f904a902f6cfd6597fde54d1597a9
---
 .zuul.yaml |  2 --
 pylint.rc  | 24 +-----------------------
 tox.ini    | 23 ++---------------------
 3 files changed, 3 insertions(+), 46 deletions(-)

diff --git a/.zuul.yaml b/.zuul.yaml
index 530a1ffaa..85102bbf1 100644
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -167,8 +167,6 @@
     parent: openstack-tox-pylint
     required-projects:
       - starlingx/config
-      - starlingx/fault
-      - starlingx/update
 
 - job:
     name: stx-integ-upload-git-mirror
diff --git a/pylint.rc b/pylint.rc
index 1de288573..4bd875a0d 100755
--- a/pylint.rc
+++ b/pylint.rc
@@ -106,33 +106,11 @@ enable=E1603,E1609,E1610,E1602,E1606,E1608,E1607,E1605,E1604,E1601,E1611,W1652,
 # can either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where
 # it should appear only once).
-# E0203 access-member-before-definition
-# E0602 undefined-variable
-# E1101 no-member
-# E1205 logging-too-many-args
-# fixme
-# W0102 dangerous-default-value
 # W0105 pointless-string-statement
-# W0106 expression-not-assigned
-# W0201 attribute-defined-outside-init
-# W0212 protected-access
-# W0221 arguments-differ
-# W0231 super-init-not-called
-# W0235 useless-super-delegation
-# W0611 unused-import
-# W0612 Unused variable warning
-# W0613 Unused argument warning
 # W0621 redefined-outer-name
-# W0622 redefined-builtin
-# W0702 bare-except
 # W0703 broad except warning
 # W0707 raise-missing-from
-# W1201 logging-not-lazy
-# W1401 anomalous-backslash-in-string
-# W1618: no-absolute-import
-disable=C, R, E0203, E0602, E1101, E1205, fixme,
-        W0102, W0105, W0106, W0201, W0212, W0221, W0231, W0235,
-        W0611, W0612, W0613, W0621, W0622, W0702, W0703, W0707, W1201, W1401, W1618
+disable=C, R, W0105, W0621, W0703, W0707
 
 
 [REPORTS]
diff --git a/tox.ini b/tox.ini
index 2a1d26aae..bfe1c09eb 100644
--- a/tox.ini
+++ b/tox.ini
@@ -5,7 +5,7 @@ skipsdist = True
 stxdir = {toxinidir}/..
 
 [testenv]
-install_command = pip install --use-deprecated legacy-resolver -U \
+install_command = pip install  --use-deprecated legacy-resolver  -U \
   -c{env:UPPER_CONSTRAINTS_FILE:https://opendev.org/openstack/requirements/raw/branch/stable/stein/upper-constraints.txt} \
   {opts} {packages}
 setenv = VIRTUAL_ENV={envdir}
@@ -92,29 +92,10 @@ commands =
 [testenv:pylint]
 basepython = python3
 deps = -r{toxinidir}/test-requirements.txt
-       -e{[tox]stxdir}/config/tsconfig/tsconfig
-       -e{[tox]stxdir}/fault/fm-api/source
-       -e{[tox]stxdir}/config/sysinv/sysinv/sysinv
        -e{[tox]stxdir}/config/sysinv/cgts-client/cgts-client
-       docutils
-       keyring===18.0.1
-       pkgconfig
-       libvirt-python
-       oslo_i18n
-       oslo_log
-       oslo_messaging
-       oslo_service
-       python-cephclient
-       python-cinderclient
-       python-glanceclient
-       python-keystoneclient
-       python-novaclient
-       SQLAlchemy
-       retrying
-       python-daemon==2.1.2
        pylint
 
-# There are currenrly 1 python module with a setup.py file
+# Currently only one python module with a setup.py file
 commands = pylint --rcfile=./pylint.rc \
            tools/storage-topology/storage-topology/storage_topology