starlingx
/
integ
Code Issues Proposed changes

Enable Flake8 E12X Errors 

Flake8 currently ignores the following Errors:
E121: continuation line under-indented for hanging indent
E123: closing bracket doesn't match indentation of opening bracket
E124: closing bracket doesn't match visual indentation
E125: continuation line with same indent as next logical line
E126: continuation line over-indented for hanging indent
E127: continuation line over-indented for visual indent
E128: continuation line under-indented for visual indent
Enable them for more consistent formatting of code

Change-Id: I415d4824a1f335ba3fceb488b0ae60b9861a036a
Story: 2004515
Task: 30076
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
This commit is contained in:
Eric Barrett 2019-03-29 08:59:40 -04:00
parent 98f2ff7bf4
commit 7bf3a477f3
11 changed files with 90 additions and 99 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ceph/ceph-manager/ceph-manager/ceph_manager/exception.py
View File

@ -33,13 +33,13 @@ class CephManagerException(Exception):
class CephPoolSetQuotaFailure(CephManagerException): class CephPoolSetQuotaFailure(CephManagerException):
message = _("Error seting the OSD pool " message = _("Error seting the OSD pool "
"quota %(name)s for %(pool)s to %(value)s") \ "quota %(name)s for %(pool)s to "
+ ": %(reason)s" "%(value)s") + ": %(reason)s"
class CephPoolGetQuotaFailure(CephManagerException): class CephPoolGetQuotaFailure(CephManagerException):
message = _("Error geting the OSD pool quota for %(pool)s") \ message = _("Error geting the OSD pool quota for "
+ ": %(reason)s" "%(pool)s") + ": %(reason)s"
class CephPoolCreateFailure(CephManagerException): class CephPoolCreateFailure(CephManagerException):

8
logging/logmgmt/logmgmt/logmgmt/logmgmt.py
View File

@ -147,10 +147,10 @@ class LogMgmtDaemon():
continue continue
# Ignore some files # Ignore some files
if '/var/log/puppet' in fname \ if ('/var/log/puppet' in fname
or '/var/log/dmesg' in fname \ or '/var/log/dmesg' in fname
or '/var/log/rabbitmq' in fname \ or '/var/log/rabbitmq' in fname
or '/var/log/lastlog' in fname: or '/var/log/lastlog' in fname):
continue continue
if os.path.exists(fname): if os.path.exists(fname):

3
logging/logmgmt/logmgmt/setup.py
View File

@ -14,6 +14,5 @@ setuptools.setup(name='logmgmt',
description='logmgmt', description='logmgmt',
license='Apache-2.0', license='Apache-2.0',
packages=['logmgmt'], packages=['logmgmt'],
entry_points={ entry_points={}
}
) )

10
tox.ini
View File

@ -37,13 +37,6 @@ commands =
[flake8] [flake8]
# E series are pep8 # E series are pep8
# E121 continuation line under-indented for hanging indent
# E123 closing bracket does not match indentation of opening bracket's line
# E124 closing bracket does not match visual indentation
# E125 continuation line with same indent as next logical line
# E126 continuation line over-indented for hanging indent
# E127 continuation line over-indented for visual indent
# E128 continuation line under-indented for visual indent
# E265 block comment should start with '# ' # E265 block comment should start with '# '
# E266 too many leading '#' for block comment # E266 too many leading '#' for block comment
# E302 expected 2 blank lines, found 1 # E302 expected 2 blank lines, found 1
@ -76,8 +69,7 @@ commands =
# B301 Python 3 does not include `.iter*` methods on dictionaries. # B301 Python 3 does not include `.iter*` methods on dictionaries.
# F series # F series
# F401 'module' imported but unused # F401 'module' imported but unused
ignore = E121,E123,E124,E125,E126,E127,E128,E265,E266, ignore = E265,E266,E302,E303,E305,E402,E501,E722
E302,E303,E305,E402,E501,E722
H101,H102,H104,H201,H238,H237,H306,H401,H404,H405, H101,H102,H104,H201,H238,H237,H306,H401,H404,H405,
W191,W291,W391,W503, W191,W291,W391,W503,
B001,B007,B009,B010,B301, B001,B007,B009,B010,B301,