From b2c6c1a8d2225d5c52611bab6b3a3d3d4ca28d90 Mon Sep 17 00:00:00 2001 From: Gerrit User 8768 <8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 25 Apr 2024 17:48:45 +0000 Subject: [PATCH] Update patch set 5 Patch Set 5: (1 comment) Patch-set: 5 Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"} --- 7d89eb2d3510e02e100293abf5cdb5504fb41d12 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/7d89eb2d3510e02e100293abf5cdb5504fb41d12 b/7d89eb2d3510e02e100293abf5cdb5504fb41d12 index f70226cdf..5bf6a2b8b 100644 --- a/7d89eb2d3510e02e100293abf5cdb5504fb41d12 +++ b/7d89eb2d3510e02e100293abf5cdb5504fb41d12 @@ -16,6 +16,24 @@ "message": "Are these simply reference or is there a gerrit depends-on like link needed here?", "revId": "7d89eb2d3510e02e100293abf5cdb5504fb41d12", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "4a5b3505_79d8434b", + "filename": "/COMMIT_MSG", + "patchSetId": 4 + }, + "lineNbr": 24, + "author": { + "id": 8768 + }, + "writtenOn": "2024-04-25T17:48:45Z", + "side": 1, + "message": "there are three commits that all need to go in together, so I can\u0027t do formal Depends-On for all three because that would cause a circular dependency. And it\u0027s too much of a pain to stage it in a series of commits that would work with both symlinks and bindmounts.\n\nhttps://review.opendev.org/c/starlingx/stx-puppet/+/916338 depends on this change, and then https://review.opendev.org/c/starlingx/ansible-playbooks/+/916336 depends on both this change and the puppet change. So if we approve them first and this one last, all three will go in at basically the same time.", + "parentUuid": "e75a5037_7e338ace", + "revId": "7d89eb2d3510e02e100293abf5cdb5504fb41d12", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file