From cf973f6eab27f94f7c34f0a74419a3382de18569 Mon Sep 17 00:00:00 2001
From: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Mon, 22 Apr 2024 20:39:43 +0000
Subject: [PATCH] Update patch set 7

Patch Set 7:

(1 comment)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 34926 \u003c34926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
---
 fb3206c062e5f24648ead7f1459e5a2e59dfba09 | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/fb3206c062e5f24648ead7f1459e5a2e59dfba09 b/fb3206c062e5f24648ead7f1459e5a2e59dfba09
index a4fb00f34..0ed2c72ca 100644
--- a/fb3206c062e5f24648ead7f1459e5a2e59dfba09
+++ b/fb3206c062e5f24648ead7f1459e5a2e59dfba09
@@ -46,6 +46,30 @@
       },
       "revId": "fb3206c062e5f24648ead7f1459e5a2e59dfba09",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "240346da_c4183a64",
+        "filename": "ceph/ceph/debian/deb_folder/ceph-base.ceph.init",
+        "patchSetId": 7
+      },
+      "lineNbr": 135,
+      "author": {
+        "id": 28464
+      },
+      "writtenOn": "2024-04-22T20:39:43Z",
+      "side": 1,
+      "message": "I really don\u0027t think ilog was ever intended to mean \u0027internal\u0027, but I suppose it could.\n\nI always thought ilog meant \u0027Info Log\u0027 , wlog is Warning Log, elog is Error Log.\nThese are log macro names used in mtce and quite commonly adopted throughout a lot of starlingX scripting.\n\nThose wlog(s) you are changing to ilog(s) seem to be ERROR logs.\nI feel changing it from wlog to ilog is downgrading the severity of the call and feels misleading. Would you consider creating an elog or warn_log. Something that carries the meaning behind the log.\n\nAlso, could you show an example as a comment or better yet in the commit message of the logging change.",
+      "parentUuid": "3a5f1864_9a971340",
+      "range": {
+        "startLine": 135,
+        "startChar": 8,
+        "endLine": 135,
+        "endChar": 9
+      },
+      "revId": "fb3206c062e5f24648ead7f1459e5a2e59dfba09",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file