From aafd8aba4893579c9b3d361afdd0a7b50b7f4406 Mon Sep 17 00:00:00 2001 From: Jiping Ma Date: Thu, 24 Nov 2022 21:42:20 -0500 Subject: [PATCH] CentOS: kdump: remove unnecessary bootargs The 5.10.74 preempt-rt kernel reports the following warning when dumping vmcore files due to the use of kernel command line arguments such as nohz_full=, isolcpus=, rcu_nocbs= with the kexec/kdump kernel. [ 1.568059] WARNING: CPU: 0 PID: 0 at kernel/time/tick-sched.c:139 tick_sched_do_timer+0x5e/0x70 [ 1.568064] Modules linked in: [ 1.568066] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G I 5.10.74-200.1648.tis.rt.el7.x86_64 #1 [ 1.568068] Hardware name: Dell Inc. PowerEdge R740/0WRPXK, BIOS 2.10.2 02/24/2021 [ 1.568068] RIP: 0010:tick_sched_do_timer+0x5e/0x70 [ 1.568071] Code: 01 00 75 26 89 15 26 74 6f 01 48 8b 05 1b 87 d5 01 Commit 1655ee30e6("sched/isolation: really align nohz_full with rcu_nocbs") is included in the 5.10.112 kernel, that had fixed the warning. So the warning will not be reproduced with 5.10.112 and the later versions of kernel. We can remove the irqaffinity, isolcpus, nohz_full, rcu_nocbs, and kthread_cpus arguments from the kdump kernel's command line arguments, which will also fix the issue. Testing: - An ISO image can be built successfully. - There are no warnings after the fix with 5.10.74 kernel. Closes-Bug: 1997932 Signed-off-by: M. Vefa Bicakci Signed-off-by: Jiping Ma Reported-by: M. Vefa Bicakci Change-Id: I7d1dbd864fdfe2533197084d7274ef6ab70892db --- tools/kexec-tools/files/kdump.sysconfig.x86_64 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kexec-tools/files/kdump.sysconfig.x86_64 b/tools/kexec-tools/files/kdump.sysconfig.x86_64 index 9595271ec..2d4ae42ff 100644 --- a/tools/kexec-tools/files/kdump.sysconfig.x86_64 +++ b/tools/kexec-tools/files/kdump.sysconfig.x86_64 @@ -17,7 +17,7 @@ KDUMP_COMMANDLINE="" # This variable lets us remove arguments from the current kdump commandline # as taken from either KDUMP_COMMANDLINE above, or from /proc/cmdline # NOTE: some arguments such as crashkernel will always be removed -KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug kaslr" +KDUMP_COMMANDLINE_REMOVE="hugepages hugepagesz slub_debug kaslr irqaffinity isolcpus nohz_full rcu_nocbs kthread_cpus" # This variable lets us append arguments to the current kdump commandline # after processed by KDUMP_COMMANDLINE_REMOVE