starlingx
/
manifest
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(4 comments)

Patch-set: 1
Reviewer: Gerrit User 36728 <36728@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, ae87aba90470f49052b6668c25bea566e518e7b9
Attention: {"person_ident":"Gerrit User 36728 \u003c36728@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36728\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36340 \u003c36340@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36728\u003e replied on the change"}
This commit is contained in:
Gerrit User 36728 2024-04-26 15:15:20 +00:00 committed by Gerrit Code Review
parent 4cb599c615
commit d77f7e74d3
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
8f6facd5282f040943af22db134d1cba78bac5a3 Normal file
View File

@ -0,0 +1,72 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7b5970b6_1f87abaa",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 10,
"author": {
"id": 36728
},
"writtenOn": "2024-04-26T15:15:20Z",
"side": 1,
"message": "This task refers to another action item. Please add a new one and update it here. Also, add the task under stx/manifest",
"revId": "8f6facd5282f040943af22db134d1cba78bac5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9bacfeab_b4268f6f",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 11,
"author": {
"id": 36728
},
"writtenOn": "2024-04-26T15:15:20Z",
"side": 1,
"message": "We\u0027re missing the Author field",
"revId": "8f6facd5282f040943af22db134d1cba78bac5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "311ebab1_7fe96fad",
"filename": "default.xml",
"patchSetId": 1
},
"lineNbr": 114,
"author": {
"id": 36728
},
"writtenOn": "2024-04-26T15:15:20Z",
"side": 1,
"message": "nit: remove this new line",
"revId": "8f6facd5282f040943af22db134d1cba78bac5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e53e1883_49192116",
"filename": "flock.xml",
"patchSetId": 1
},
"lineNbr": 60,
"author": {
"id": 36728
},
"writtenOn": "2024-04-26T15:15:20Z",
"side": 1,
"message": "The entry is duplicated here",
"revId": "8f6facd5282f040943af22db134d1cba78bac5a3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}