From 127ace6e2186641163f8b2eaa093b65d9fbaba1e Mon Sep 17 00:00:00 2001
From: Gerrit User 32933 <32933@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Thu, 18 Apr 2024 11:04:29 +0000
Subject: [PATCH] Update patch set 3

Patch Set 3: Code-Review+1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 32933 <32933@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, fb84f68f20497a9a2383152c53b88902f907b86d
Attention: {"person_ident":"Gerrit User 35022 \u003c35022@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32933\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32933 \u003c32933@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32933\u003e replied on the change"}
---
 9821652bc8174cc8a037b160421af23992a7dc7e | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/9821652bc8174cc8a037b160421af23992a7dc7e b/9821652bc8174cc8a037b160421af23992a7dc7e
index 4a52851e..72697365 100644
--- a/9821652bc8174cc8a037b160421af23992a7dc7e
+++ b/9821652bc8174cc8a037b160421af23992a7dc7e
@@ -16,6 +16,24 @@
       "message": "I believe you will need to think about upgrade scenarios.\nThe previous release will not have the dual stack support,\nit will run the old code, I think this code will work fine for a straight upgrade process.\nBut maybe for upgrade-abort scenarios or if the active controller is running the new code and some node reboots and it is still running the old code, it may not work;\nAt this moment, the node running the old code will try to resolve the \"controller.internal\" and the active controller will answer the IP for controller.internal for IPv6 and IPv4.\n\nYou can merge this code, it as a clean solution, but in the next tasks we may need to handle these scenarios.",
       "revId": "9821652bc8174cc8a037b160421af23992a7dc7e",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "e35f6cf3_54da9c87",
+        "filename": "kickstart/files/kickstart.cfg",
+        "patchSetId": 3
+      },
+      "lineNbr": 2722,
+      "author": {
+        "id": 32933
+      },
+      "writtenOn": "2024-04-18T11:04:29Z",
+      "side": 1,
+      "message": "It should work as mgmt_ip query the active controller and does not attempt to get it differently in case of failure. This makes me believe the API is already present in the previous version.",
+      "parentUuid": "bb46db74_bc5291f6",
+      "revId": "9821652bc8174cc8a037b160421af23992a7dc7e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file